Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix commented out tests in test_syntax #76028

Closed
serhiy-storchaka opened this issue Oct 23, 2017 · 3 comments
Closed

Fix commented out tests in test_syntax #76028

serhiy-storchaka opened this issue Oct 23, 2017 · 3 comments
Assignees
@serhiy-storchaka
Labels
3.7 (EOL) end of life tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

BPO 31847
Nosy @serhiy-storchaka
PRs
  • bpo-31847: Fix commented out tests in test_syntax. #4084
  • [3.6] bpo-31847: Fix commented out tests in test_syntax. (GH-4084) #4095
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2017-10-24.05:34:29.277>
created_at = <Date 2017-10-23.12:52:13.850>
labels = ['3.7', 'type-feature', 'tests']
title = 'Fix commented out tests in test_syntax'
updated_at = <Date 2017-10-24.05:34:29.276>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2017-10-24.05:34:29.276>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2017-10-24.05:34:29.277>
closer = 'serhiy.storchaka'
components = ['Tests']
creation = <Date 2017-10-23.12:52:13.850>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 31847
keywords = ['patch']
message_count = 3.0
messages = ['304800', '304845', '304848']
nosy_count = 1.0
nosy_names = ['serhiy.storchaka']
pr_nums = ['4084', '4095']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue31847'
versions = ['Python 3.6', 'Python 3.7']
    @serhiy-storchaka
    Copy link
    Member Author

    Two doctest tests in test_syntax are commented out because SyntaxWarning was expected, but doctests couldn't be used for testing them.

    But now SyntaxError is raised in these cases instead of SyntaxWarning.

    The proposed PR restores and fixes tests.

    @serhiy-storchaka serhiy-storchaka added the 3.7 (EOL) end of life label Oct 23, 2017
    @serhiy-storchaka serhiy-storchaka self-assigned this Oct 23, 2017
    @serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir type-feature A feature request or enhancement labels Oct 23, 2017
    @serhiy-storchaka
    Copy link
    Member Author

    New changeset 3b66ebe by Serhiy Storchaka in branch 'master':
    bpo-31847: Fix commented out tests in test_syntax. (bpo-4084)
    3b66ebe

    @serhiy-storchaka
    Copy link
    Member Author

    New changeset d7604f5 by Serhiy Storchaka (Miss Islington (bot)) in branch '3.6':
    bpo-31847: Fix commented out tests in test_syntax. (GH-4084) (bpo-4095)
    d7604f5

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @serhiy-storchaka serhiy-storchaka

    Labels
    3.7 (EOL) end of life tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @serhiy-storchaka