This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Fix commented out tests in test_syntax
Type: enhancement Stage: resolved
Components: Tests Versions: Python 3.7, Python 3.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: serhiy.storchaka Nosy List: serhiy.storchaka
Priority: normal Keywords: patch

Created on 2017-10-23 12:52 by serhiy.storchaka, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 4084 merged serhiy.storchaka, 2017-10-23 12:54
PR 4095 merged python-dev, 2017-10-23 21:27
Messages (3)
msg304800 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-10-23 12:52
Two doctest tests in test_syntax are commented out because SyntaxWarning was expected, but doctests couldn't be used for testing them.

But now SyntaxError is raised in these cases instead of SyntaxWarning.

The proposed PR restores and fixes tests.
msg304845 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-10-23 21:27
New changeset 3b66ebe7727dba68c2c6ccf0cd85a4c31255b9b4 by Serhiy Storchaka in branch 'master':
bpo-31847: Fix commented out tests in test_syntax. (#4084)
https://github.com/python/cpython/commit/3b66ebe7727dba68c2c6ccf0cd85a4c31255b9b4
msg304848 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-10-23 22:08
New changeset d7604f5d0621c23d037455acd682d0d489455d54 by Serhiy Storchaka (Miss Islington (bot)) in branch '3.6':
bpo-31847: Fix commented out tests in test_syntax. (GH-4084) (#4095)
https://github.com/python/cpython/commit/d7604f5d0621c23d037455acd682d0d489455d54
History
Date User Action Args
2022-04-11 14:58:53adminsetgithub: 76028
2017-10-24 05:34:29serhiy.storchakasetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2017-10-23 22:08:05serhiy.storchakasetmessages: + msg304848
2017-10-23 21:27:41python-devsetpull_requests: + pull_request4066
2017-10-23 21:27:17serhiy.storchakasetmessages: + msg304845
2017-10-23 12:54:35serhiy.storchakasetkeywords: + patch
pull_requests: + pull_request4054
2017-10-23 12:52:13serhiy.storchakacreate