Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDLE: Test config dialog font bold button and sample change #75164

Closed
terryjreedy opened this issue Jul 21, 2017 · 10 comments
Closed

IDLE: Test config dialog font bold button and sample change #75164

terryjreedy opened this issue Jul 21, 2017 · 10 comments
Assignees
@terryjreedy
Labels
3.7 (EOL) end of life topic-IDLE type-feature A feature request or enhancement

Comments

@terryjreedy
Copy link
Member

BPO 30981
Nosy @terryjreedy
PRs
  • bpo-30981: IDLE -- Add more configdialog font page tests.  #2794
  • [3.6] bpo-30981: IDLE -- Add more configdialog font page tests. (GH-… #2796
  • bpo-30981: temporarity skip failing IDLE test class #2798
  • bpo-30981: IDLE: Add more configdialog font page tests. #2805
  • bpo-30981: IDLE: Augment one configdialog font page test #2810
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2017-07-22.04:58:45.585>
created_at = <Date 2017-07-21.02:19:00.484>
labels = ['expert-IDLE', 'type-feature', '3.7']
title = 'IDLE: Test config dialog font bold button and sample change'
updated_at = <Date 2017-07-22.19:33:43.898>
user = 'https://github.com/terryjreedy'

    bugs.python.org fields:

    activity = <Date 2017-07-22.19:33:43.898>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2017-07-22.04:58:45.585>
closer = 'terry.reedy'
components = ['IDLE']
creation = <Date 2017-07-21.02:19:00.484>
creator = 'terry.reedy'
dependencies = []
files = []
hgrepos = []
issue_num = 30981
keywords = []
message_count = 10.0
messages = ['298761', '298770', '298771', '298776', '298779', '298780', '298781', '298834', '298837', '298867']
nosy_count = 1.0
nosy_names = ['terry.reedy']
pr_nums = ['2794', '2796', '2798', '2805', '2810']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue30981'
versions = ['Python 3.6', 'Python 3.7']
    @terryjreedy terryjreedy added the 3.7 (EOL) end of life label Jul 21, 2017
    @terryjreedy terryjreedy self-assigned this Jul 21, 2017
    @terryjreedy terryjreedy added topic-IDLE type-feature A feature request or enhancement labels Jul 21, 2017
    @terryjreedy
    Copy link
    Member Author

    I am working on this.

    • Change 'test_highlight_sample' to 'highlight_sample.
    • Change 'set_font_sample()' to 'set_samples()', since it also changes highlight_sample, and test.
    • Add gui event test for 'bold' checkbutton.
    • Perhaps add gui event test for size pulldown, or wait until replace.
    • Test tab setting or wait until replace.

    Do this before bpo-24776 to redo page and bpo-13802 to redo sample

    @terryjreedy
    Copy link
    Member Author

    New changeset d0969d6 by Terry Jan Reedy in branch 'master':
    bpo-30981: IDLE -- Add more configdialog font page tests. (bpo-2794)
    d0969d6

    @terryjreedy
    Copy link
    Member Author

    I left out gui event tests since they depends on the widgets, which will likely change. I though about tests for the uncovered load_font_config and load_tab_config, but am not sure what to do that would not amount to copying their code.

    @terryjreedy
    Copy link
    Member Author

    Viktor, I am aware that there are errors in the patch I pushed that will result in error on the Windows machines that run gui tests. Am working on a fix now.

    @terryjreedy
    Copy link
    Member Author

    I am too tired to fix this correctly right now, so I added @Skip to class with failing tests.

    @terryjreedy
    Copy link
    Member Author

    New changeset 7c5798e by Terry Jan Reedy in branch 'master':
    bpo-30981: temporarity skip failing IDLE test class (bpo-2798)
    7c5798e

    @vstinner
    Copy link
    Member

    Thanks for the fix :-) (Don't forget to fix it later ;-))

    @terryjreedy
    Copy link
    Member Author

    New changeset 616ecf1 by Terry Jan Reedy in branch 'master':
    bpo-30981: IDLE: Augment one configdialog font page test (bpo-2810)
    616ecf1

    @terryjreedy
    Copy link
    Member Author

    New changeset 04864b4 by Terry Jan Reedy in branch '3.6':
    [3.6] bpo-30981: IDLE -- Add more configdialog font page tests. (GH-… (bpo-2796)
    04864b4

    @terryjreedy terryjreedy changed the title IDLE: Add config dialog font page tests IDLE: Test config dialog font bold button and sample change Jul 22, 2017
    @terryjreedy
    Copy link
    Member Author

    Followup issue is bpo-30993.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @terryjreedy terryjreedy

    Labels
    3.7 (EOL) end of life topic-IDLE type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @vstinner @terryjreedy