Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDLE: Fix configdialog should use wm_withdraw #75083

Closed
mlouielu mannequin opened this issue Jul 11, 2017 · 4 comments
Closed

IDLE: Fix configdialog should use wm_withdraw #75083

mlouielu mannequin opened this issue Jul 11, 2017 · 4 comments
Assignees
@terryjreedy
Labels
3.7 (EOL) end of life topic-IDLE

Comments

@mlouielu
Copy link
Mannequin

mlouielu mannequin commented Jul 11, 2017

BPO 30900
Nosy @terryjreedy, @mlouielu, @csabella
PRs
  • bpo-30900: IDLE: Fix configdialog should use wm_withdraw #2664
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2017-07-11.07:50:23.446>
created_at = <Date 2017-07-11.07:05:27.549>
labels = ['expert-IDLE', '3.7', 'invalid']
title = 'IDLE: Fix configdialog should use wm_withdraw'
updated_at = <Date 2017-07-11.07:56:46.298>
user = 'https://github.com/mlouielu'

    bugs.python.org fields:

    activity = <Date 2017-07-11.07:56:46.298>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2017-07-11.07:50:23.446>
closer = 'louielu'
components = ['IDLE']
creation = <Date 2017-07-11.07:05:27.549>
creator = 'louielu'
dependencies = []
files = []
hgrepos = []
issue_num = 30900
keywords = []
message_count = 4.0
messages = ['298136', '298141', '298142', '298143']
nosy_count = 3.0
nosy_names = ['terry.reedy', 'louielu', 'cheryl.sabella']
pr_nums = ['2664']
priority = 'normal'
resolution = 'not a bug'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue30900'
versions = ['Python 3.6', 'Python 3.7']
    @mlouielu
    Copy link
    Mannequin Author

    mlouielu mannequin commented Jul 11, 2017

    Introduce in bpo-30728, commit bac7d33, self.wm_withdraw has been changed into self.withdraw. This make bpo-30870 un-testable since it using self.withdraw will block out event_generate.

    This issue revert self.widthdraw to self.wm_withdraw.

    @mlouielu mlouielu mannequin added the 3.7 (EOL) end of life label Jul 11, 2017
    @mlouielu mlouielu mannequin assigned terryjreedy Jul 11, 2017
    @mlouielu mlouielu mannequin added the topic-IDLE label Jul 11, 2017
    @terryjreedy
    Copy link
    Member

    Color me dubious ;-). The change was made because tkinter.__init__, line 1990 has this line
    withdraw = wm_withdraw
    There is a similar line for all of the around 30 wm_xyz functions. Prefixing the names of methods of class Wm is an unusual redundancy. I cannot think of any sane way for tk to know which python synonym was used to call the Python wrapper.

    What code using event_generate led you to this conclusion?

    @mlouielu
    Copy link
    Mannequin Author

    mlouielu mannequin commented Jul 11, 2017

    Hmmm, I think it is a mistake of my test, it is something inside configdialog init make unittest can't do event_generate, but not this one self.withdraw.

    @mlouielu mlouielu mannequin closed this as completed Jul 11, 2017
    @mlouielu mlouielu mannequin added the invalid label Jul 11, 2017
    @terryjreedy
    Copy link
    Member

    I first beat my head against event_generate two or three years ago. So I appreciate you taking a whack at it. It is nice that Variable.set and invoke can be used for tests, but it would really be nice to have e_v work too.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @terryjreedy terryjreedy

    Labels
    3.7 (EOL) end of life topic-IDLE
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @terryjreedy