This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: IDLE: Fix configdialog should use wm_withdraw
Type: Stage: resolved
Components: IDLE Versions: Python 3.7, Python 3.6
Status: closed Resolution: not a bug
Dependencies: Superseder:
Assigned To: terry.reedy Nosy List: cheryl.sabella, louielu, terry.reedy
Priority: normal Keywords:

Created on 2017-07-11 07:05 by louielu, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 2664 closed louielu, 2017-07-11 07:06
Messages (4)
msg298136 - (view) Author: Louie Lu (louielu) * Date: 2017-07-11 07:05
Introduce in #30728, commit bac7d3363b099d, `self.wm_withdraw` has been changed into `self.withdraw`. This make #30870 un-testable since it using `self.withdraw` will block out `event_generate`.

This issue revert `self.widthdraw` to `self.wm_withdraw`.
msg298141 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-07-11 07:41
Color me dubious ;-). The change was made because tkinter.__init__, line 1990 has this line
    withdraw = wm_withdraw
There is a similar line for all of the around 30 wm_xyz functions. Prefixing the names of methods of class Wm is an unusual redundancy.  I cannot think of any sane way for tk to know which python synonym was used to call the Python wrapper.

What code using event_generate led you to this conclusion?
msg298142 - (view) Author: Louie Lu (louielu) * Date: 2017-07-11 07:50
Hmmm, I think it is a mistake of my test, it is something inside configdialog __init__ make unittest can't do event_generate, but not this one `self.withdraw`.
msg298143 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-07-11 07:56
I first beat my head against event_generate two or three years ago.  So I appreciate you taking a whack at it.  It is nice that Variable.set and invoke can be used for tests, but it would really be nice to have e_v work too.
Date User Action Args
2022-04-11 14:58:48adminsetgithub: 75083
2017-07-11 07:56:46terry.reedysetmessages: + msg298143
2017-07-11 07:50:23louielusetstatus: open -> closed
resolution: not a bug
messages: + msg298142

stage: resolved
2017-07-11 07:41:50terry.reedysetmessages: + msg298141
2017-07-11 07:06:50louielusetpull_requests: + pull_request2729
2017-07-11 07:05:27louielucreate