Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDLE: add unittests to test_autocomplete #74817

Closed
mlouielu mannequin opened this issue Jun 12, 2017 · 4 comments
Closed

IDLE: add unittests to test_autocomplete #74817

mlouielu mannequin opened this issue Jun 12, 2017 · 4 comments
Assignees
@terryjreedy
Labels
3.7 (EOL) end of life topic-IDLE type-feature A feature request or enhancement

Comments

@mlouielu
Copy link
Mannequin

mlouielu mannequin commented Jun 12, 2017

BPO 30632
Nosy @terryjreedy, @mlouielu
PRs
  • bpo-30632: IDLE: Add three unittest to test_autocomplete #2124
    		•
    Superseder
  • bpo-30348: IDLE: Add test_autocomplete unittests
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2017-06-15.03:07:20.856>
created_at = <Date 2017-06-12.08:30:22.830>
labels = ['expert-IDLE', 'type-feature', '3.7']
title = 'IDLE: add unittests to test_autocomplete'
updated_at = <Date 2017-10-13.04:42:07.541>
user = 'https://github.com/mlouielu'

    bugs.python.org fields:

    activity = <Date 2017-10-13.04:42:07.541>
actor = 'berker.peksag'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2017-06-15.03:07:20.856>
closer = 'louielu'
components = ['IDLE']
creation = <Date 2017-06-12.08:30:22.830>
creator = 'louielu'
dependencies = []
files = []
hgrepos = []
issue_num = 30632
keywords = []
message_count = 4.0
messages = ['295755', '295806', '296028', '296061']
nosy_count = 2.0
nosy_names = ['terry.reedy', 'louielu']
pr_nums = ['2124']
priority = 'normal'
resolution = 'duplicate'
stage = 'resolved'
status = 'closed'
superseder = '30348'
type = 'enhancement'
url = 'https://bugs.python.org/issue30632'
versions = ['Python 3.7']
    @mlouielu
    Copy link
    Mannequin Author

    mlouielu mannequin commented Jun 12, 2017

    Add unittest to test_open_completions, test_fetch_copmletions, and test_get_entity in test_autocomplete

    @mlouielu mlouielu mannequin added the 3.7 (EOL) end of life label Jun 12, 2017
    @mlouielu mlouielu mannequin assigned terryjreedy Jun 12, 2017
    @mlouielu mlouielu mannequin added topic-IDLE type-feature A feature request or enhancement labels Jun 12, 2017
    @terryjreedy
    Copy link
    Member

    This issue, and in part the patch, appears to be a duplicate of bpo-30348. What am I missing? An issue can have multiple PRs, and one can either replace another one that is closed or augment one that must be applied first.

    @terryjreedy
    Copy link
    Member

    Ping. Please answer question about two PRs.

    For bpo-30666, I wrote

    1. Test_autocomplete.AutoCompleteTest has a test_method for each method of autocomplete.AutoComplete. The last 5 test methods are empty ('pass'). Finish them. A couple of the methods might be usefully split into smaller methods. Get_entity is actually a function, as 'self' is ignored. After the first else, fetch_completions is also independent of 'self'. PR 2011 combines the two blocks into a function that can be moved to run.py.

    These method tests should be supplemented by user action tests with live widgets and simulated key events. Such tests would be black box tests in that they should be independent of the implementation.

    I decided to broaden this issue to all autocomplete tests and narrow that one to autocomplete_w tests.

    @terryjreedy terryjreedy changed the title IDLE: add unittest to test_autocomplete IDLE: add unittests to test_autocomplete Jun 14, 2017
    @mlouielu
    Copy link
    Mannequin Author

    mlouielu mannequin commented Jun 15, 2017

    This is a duplicate of bpo-30348, I forgot there has a exists PR. I'll combine them and finish left 5 unittest in bpo-30348.

    @mlouielu mlouielu mannequin closed this as completed Jun 15, 2017
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @terryjreedy terryjreedy

    Labels
    3.7 (EOL) end of life topic-IDLE type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @terryjreedy