Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_subprocess creates a core dump on FreeBSD #74633

Closed
vstinner opened this issue May 24, 2017 · 9 comments
Closed

test_subprocess creates a core dump on FreeBSD #74633

vstinner opened this issue May 24, 2017 · 9 comments
Labels
3.7 (EOL) end of life tests Tests in the Lib/test dir

Comments

@vstinner
Copy link
Member

BPO 30448
Nosy @ronaldoussoren, @vstinner, @ned-deily, @ericsnowcurrently
PRs
  • [2.7] bpo-30448: Try to fix test_subprocess on macOS #2515
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2017-06-30.23:41:31.481>
    created_at = <Date 2017-05-24.00:24:03.414>
    labels = ['3.7', 'tests']
    title = 'test_subprocess creates a core dump on FreeBSD'
    updated_at = <Date 2017-06-30.23:41:31.477>
    user = 'https://github.com/vstinner'

    bugs.python.org fields:

    activity = <Date 2017-06-30.23:41:31.477>
    actor = 'vstinner'
    assignee = 'none'
    closed = True
    closed_date = <Date 2017-06-30.23:41:31.481>
    closer = 'vstinner'
    components = ['Tests']
    creation = <Date 2017-05-24.00:24:03.414>
    creator = 'vstinner'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 30448
    keywords = []
    message_count = 9.0
    messages = ['294303', '294318', '294320', '294512', '294824', '296971', '297055', '297453', '297454']
    nosy_count = 4.0
    nosy_names = ['ronaldoussoren', 'vstinner', 'ned.deily', 'eric.snow']
    pr_nums = ['2515']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue30448'
    versions = ['Python 2.7', 'Python 3.5', 'Python 3.6', 'Python 3.7']

    @vstinner
    Copy link
    Member Author

    Eric Snow: do you think that it could be related to your recent subinterpreter changes please?

    http://buildbot.python.org/all/builders/AMD64%20FreeBSD%20CURRENT%20Debug%203.x/builds/311/steps/test/logs/stdio

    0:08:26 load avg: 3.35 [253/405] test_subprocess failed (env changed) (98 sec) -- running: test_io (30 sec)

    Warning -- files was modified by test_subprocess
    Before: []
    After: ['python.core']

    @vstinner vstinner added 3.7 (EOL) end of life tests Tests in the Lib/test dir labels May 24, 2017
    @ericsnowcurrently
    Copy link
    Member

    That looks similar to other failures due to an issue fixed in a later PR. It shouldn't be an issue any longer. I'll double check in the morning.

    @vstinner
    Copy link
    Member Author

    I'm surprised that we only detect hard crashes only indirectly through the
    creation of core dump files... Some tests might be enhanced to raise an
    exception at least if the process was killed by a signal, maybe also if the
    exit code is non-zero (depending on the test).

    We had a similar but different issue in test_io which created a core dump
    on a deliberate crash.

    @ericsnowcurrently
    Copy link
    Member

    At this point I'm not convinced the failure is due to my recent changes. Regardless, I do agree with you about detecting hard crashes.

    @vstinner
    Copy link
    Member Author

    Sadly, I'm unable to reproduce the issue on my FreeBSD 11 VM :-(

    @vstinner
    Copy link
    Member Author

    Oops, I mentioned the wrong bpo in my PRs: the fix was pushed using bpo-30764 identifier :-/

    @vstinner
    Copy link
    Member Author

    It seems like test_child_terminated_in_stopped_state() of test_subprocess on Python 2.7 fails on some macOS versions, see:
    http://bugs.python.org/issue30764#msg296966

    Can someone please try to reproduce the bug? I'm unable to reproduce the bug on Darwin 16.5.0 (macOS Sierra?).

    @vstinner
    Copy link
    Member Author

    New changeset fd93f37 by Victor Stinner in branch '2.7':
    bpo-30448: Fix support.SuppressCrashReport on macOS (bpo-2515)
    fd93f37

    @vstinner
    Copy link
    Member Author

    macOS 2.7 buildbots are back. All known bugs are fixed, I close the issue.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life tests Tests in the Lib/test dir
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants