Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_capi, test_regrtest fail when multithreading disabled #72670

Closed
vadmium opened this issue Oct 20, 2016 · 3 comments
Closed

test_capi, test_regrtest fail when multithreading disabled #72670

vadmium opened this issue Oct 20, 2016 · 3 comments
Labels
3.7 (EOL) end of life tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@vadmium
Copy link
Member

vadmium commented Oct 20, 2016

BPO 28484
Nosy @vstinner, @vadmium
Files
  • mt-victor.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2016-10-20.23:39:09.433>
created_at = <Date 2016-10-20.07:26:49.293>
labels = ['3.7', 'type-bug', 'tests']
title = 'test_capi, test_regrtest fail when multithreading disabled'
updated_at = <Date 2016-10-20.23:39:09.433>
user = 'https://github.com/vadmium'

    bugs.python.org fields:

    activity = <Date 2016-10-20.23:39:09.433>
actor = 'martin.panter'
assignee = 'none'
closed = True
closed_date = <Date 2016-10-20.23:39:09.433>
closer = 'martin.panter'
components = ['Tests']
creation = <Date 2016-10-20.07:26:49.293>
creator = 'martin.panter'
dependencies = []
files = ['45148']
hgrepos = []
issue_num = 28484
keywords = ['patch']
message_count = 3.0
messages = ['279017', '279020', '279091']
nosy_count = 3.0
nosy_names = ['vstinner', 'python-dev', 'martin.panter']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue28484'
versions = ['Python 3.6', 'Python 3.7']
    @vadmium
    Copy link
    Member Author

    vadmium commented Oct 20, 2016

    Two tests in test_capi assume that the GIL is always used, but I don’t think it is available when Python is built with “configure --without-threads”. So I propose to skip these tests if the “threading” module is unavailable.

    In test_regrtest, a test is rerun using the -j2 option, which fails if multithreading is disabled. I propose to only run without -j2 if “threading” does not import.

    Victor, I grouped these two changes together because both bits of code have your name on them. Hopefully you can give them a quick review :)

    @vadmium vadmium added 3.7 (EOL) end of life tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error labels Oct 20, 2016
    @vstinner
    Copy link
    Member

    Each time I see a bug error on --without-treads, I want to remove the option. We had a buildbot in the past, but I don't see it anymore.

    mt-victor.patch LGTM except of a minor comment, see my review.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 20, 2016

    New changeset b811ec148337 by Martin Panter in branch '3.6':
    Issue bpo-28484: Skip tests if GIL is not used or multithreading is disabled
    https://hg.python.org/cpython/rev/b811ec148337

    @vadmium vadmium closed this as completed Oct 20, 2016
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @vstinner @vadmium