Title: test_capi, test_regrtest fail when multithreading disabled
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.7, Python 3.6
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: martin.panter, python-dev, vstinner
Priority: normal Keywords: patch

Created on 2016-10-20 07:26 by martin.panter, last changed 2016-10-20 23:39 by martin.panter. This issue is now closed.

File name Uploaded Description Edit
mt-victor.patch martin.panter, 2016-10-20 07:26 review
Messages (3)
msg279017 - (view) Author: Martin Panter (martin.panter) * (Python committer) Date: 2016-10-20 07:26
Two tests in test_capi assume that the GIL is always used, but I don’t think it is available when Python is built with “configure --without-threads”. So I propose to skip these tests if the “threading” module is unavailable.

In test_regrtest, a test is rerun using the -j2 option, which fails if multithreading is disabled. I propose to only run without -j2 if “threading” does not import.

Victor, I grouped these two changes together because both bits of code have your name on them. Hopefully you can give them a quick review :)
msg279020 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2016-10-20 08:02
Each time I see a bug error on --without-treads, I want to remove the option. We had a buildbot in the past, but I don't see it anymore.

mt-victor.patch LGTM except of a minor comment, see my review.
msg279091 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-10-20 23:08
New changeset b811ec148337 by Martin Panter in branch '3.6':
Issue #28484: Skip tests if GIL is not used or multithreading is disabled
Date User Action Args
2016-10-20 23:39:09martin.pantersetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2016-10-20 23:08:59python-devsetnosy: + python-dev
messages: + msg279091
2016-10-20 08:03:00vstinnersetmessages: + msg279020
2016-10-20 07:26:49martin.pantercreate