Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distutils tests are broken in 3.4 #72147

Closed
larryhastings opened this issue Sep 5, 2016 · 7 comments
Closed

Distutils tests are broken in 3.4 #72147

larryhastings opened this issue Sep 5, 2016 · 7 comments
Assignees
@jaraco
Labels
release-blocker tests Tests in the Lib/test dir type-crash A hard crash of the interpreter, possibly with a core dump

Comments

@larryhastings
Copy link
Contributor

BPO 27960
Nosy @jaraco, @larryhastings, @vadmium, @zware

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/jaraco'
closed_at = <Date 2016-09-06.02:32:59.002>
created_at = <Date 2016-09-05.23:47:31.073>
labels = ['tests', 'type-crash', 'release-blocker']
title = 'Distutils tests are broken in 3.4'
updated_at = <Date 2016-09-06.02:36:44.444>
user = 'https://github.com/larryhastings'

bugs.python.org fields:

activity = <Date 2016-09-06.02:36:44.444>
actor = 'jaraco'
assignee = 'jaraco'
closed = True
closed_date = <Date 2016-09-06.02:32:59.002>
closer = 'jaraco'
components = ['Tests']
creation = <Date 2016-09-05.23:47:31.073>
creator = 'larry'
dependencies = []
files = []
hgrepos = []
issue_num = 27960
keywords = ['3.4regression']
message_count = 7.0
messages = ['274472', '274490', '274496', '274500', '274502', '274503', '274505']
nosy_count = 5.0
nosy_names = ['jaraco', 'larry', 'python-dev', 'martin.panter', 'zach.ware']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = 'needs patch'
status = 'closed'
superseder = None
type = 'crash'
url = 'https://bugs.python.org/issue27960'
versions = ['Python 3.4']
@larryhastings
Copy link
Contributor Author

3.4.5 shipped with a working test suite. Since the release of 3.4.5 somebody broke test_distutils in the 3.4 branch. It needs to be fixed.

jason.coombs: AFAICT you were the last person to touch it. Are you the one who broke it?

 % ./python -m test test_distutils
[1/1] test_distutils
test test_distutils crashed -- Traceback (most recent call last):
  File "/home/larry/src/python/broke34/Lib/test/regrtest.py", line 1279, in runtest_inner
    test_runner()
  File "/home/larry/src/python/broke34/Lib/test/test_distutils.py", line 13, in test_main
    test.support.run_unittest(distutils.tests.test_suite())
  File "/home/larry/src/python/broke34/Lib/distutils/tests/__init__.py", line 31, in test_suite
    suite.addTest(module.test_suite())
AttributeError: 'module' object has no attribute 'test_suite'

1 test failed:
test_distutils

@larryhastings larryhastings added tests Tests in the Lib/test dir type-crash A hard crash of the interpreter, possibly with a core dump labels Sep 5, 2016
@vadmium
Copy link
Member

vadmium commented Sep 6, 2016

Probably related to the <https://hg.python.org/cpython/log/3.4/Lib/distutils/tests/test_filelist.py\> changes and bpo-12885. Most of the changes were probably reverted from 3.4 in revision e82b995d1a5c, but it looks like we also need to fully revert cc86e9e102e8 to add test_suite() back.

The foolproof thing would be to copy the old working version of these files, review the diff, and check it back in as a new commit.

@jaraco
Copy link
Member

jaraco commented Sep 6, 2016

Sorry you've had to spend any time on this. I'll get it corrected immediately.

@jaraco
Copy link
Member

jaraco commented Sep 6, 2016

I invoked hg revert --all -r 675e20c38fdac6 at the 3.4 head, and that effectively reverted everything to its state prior to the commits.

@python-dev
Copy link
Mannequin

python-dev mannequin commented Sep 6, 2016

New changeset 556a11c11edd by Jason R. Coombs in branch '3.4':
Issue bpo-27960: Revert state to 675e20c38fdac6, backing out all changes by developed for Issue bpo-12885.
https://hg.python.org/cpython/rev/556a11c11edd

New changeset b442744d2d22 by Jason R. Coombs in branch '3.5':
Issue bpo-27960: Merge with 3.4
https://hg.python.org/cpython/rev/b442744d2d22

New changeset 7cec1a1d6950 by Jason R. Coombs in branch 'default':
Issue bpo-27960: Merge with 3.5
https://hg.python.org/cpython/rev/7cec1a1d6950

@jaraco
Copy link
Member

jaraco commented Sep 6, 2016

I believe this is fixed now. I'll be testing locally, but please don't hesitate to let me know if you find otherwise.

@jaraco jaraco closed this as completed Sep 6, 2016
@jaraco
Copy link
Member

jaraco commented Sep 6, 2016

Confirmed working here now.

$ hg id -i
556a11c11edd
$ ./python.exe -m test test_distutils
[1/1] test_distutils
1 test OK.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaraco jaraco

Labels
release-blocker tests Tests in the Lib/test dir type-crash A hard crash of the interpreter, possibly with a core dump
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jaraco @vadmium @larryhastings