Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mimetypes.__all__ list is incomplete #71295

Closed
Unit03 mannequin opened this issue May 24, 2016 · 6 comments
Closed

mimetypes.__all__ list is incomplete #71295

Unit03 mannequin opened this issue May 24, 2016 · 6 comments
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@Unit03
Copy link
Mannequin

Unit03 mannequin commented May 24, 2016

BPO 27108
Nosy @bitdancer, @vadmium
Files
  • mimetypes_all.patch
  • mimetypes_all.v2.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2016-06-06.02:55:25.057>
created_at = <Date 2016-05-24.20:31:36.052>
labels = ['type-feature', 'library']
title = 'mimetypes.__all__ list is incomplete'
updated_at = <Date 2016-06-06.02:55:25.056>
user = 'https://bugs.python.org/Unit03'

    bugs.python.org fields:

    activity = <Date 2016-06-06.02:55:25.056>
actor = 'martin.panter'
assignee = 'none'
closed = True
closed_date = <Date 2016-06-06.02:55:25.057>
closer = 'martin.panter'
components = ['Library (Lib)']
creation = <Date 2016-05-24.20:31:36.052>
creator = 'Unit03'
dependencies = []
files = ['42970', '42988']
hgrepos = []
issue_num = 27108
keywords = ['patch']
message_count = 6.0
messages = ['266268', '266274', '266323', '266329', '266348', '267510']
nosy_count = 4.0
nosy_names = ['r.david.murray', 'python-dev', 'martin.panter', 'Unit03']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue27108'
versions = ['Python 3.6']
    @Unit03
    Copy link
    Mannequin Author

    Unit03 mannequin commented May 24, 2016

    That's a child issue of bpo-23883, created to propose a patch fixing mimetypes module's __all__ list.

    @Unit03 Unit03 mannequin added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels May 24, 2016
    @bitdancer
    Copy link
    Member

    LGTM

    @vadmium
    Copy link
    Member

    vadmium commented May 25, 2016

    I left a comment about the empty blacklist. Other than removing the blacklist parameter, I think this is good to go.

    @Unit03
    Copy link
    Mannequin Author

    Unit03 mannequin commented May 25, 2016

    Thank you, Martin. I'm uploading amended patch.

    @bitdancer
    Copy link
    Member

    I thought having the empty blacklist was a good reminder, in case names are added later that need blacklisting (though granted that should be unlikely at this point, since we are more consistent about using _ names for internals now). I have no objection to removing it, though.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jun 6, 2016

    New changeset 2057b0af1c52 by Martin Panter in branch 'default':
    Issue bpo-27108: Add missing names to mimetypes.__all__, by Jacek Kołodziej
    https://hg.python.org/cpython/rev/2057b0af1c52

    @vadmium vadmium closed this as completed Jun 6, 2016
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @bitdancer @vadmium