➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2016-05-24 20:31 by Unit03, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| mimetypes_all.patch | Unit03, 2016-05-24 20:31 | review | ||
| mimetypes_all.v2.patch | Unit03, 2016-05-25 10:41 | review | ||
| Messages (6) | |||
|---|---|---|---|
| msg266268 - (view) | Author: Jacek Kołodziej (Unit03) * | Date: 2016-05-24 20:31 | |
That's a child issue of #23883, created to propose a patch fixing mimetypes module's __all__ list. |
|||
| msg266274 - (view) | Author: R. David Murray (r.david.murray) *  |
Date: 2016-05-24 20:53 | |
LGTM |
|||
| msg266323 - (view) | Author: Martin Panter (martin.panter) * |
Date: 2016-05-25 09:10 | |
I left a comment about the empty blacklist. Other than removing the blacklist parameter, I think this is good to go. |
|||
| msg266329 - (view) | Author: Jacek Kołodziej (Unit03) * | Date: 2016-05-25 10:41 | |
Thank you, Martin. I'm uploading amended patch. |
|||
| msg266348 - (view) | Author: R. David Murray (r.david.murray) * |
Date: 2016-05-25 13:28 | |
I thought having the empty blacklist was a good reminder, in case names are added later that need blacklisting (though granted that should be unlikely at this point, since we are more consistent about using _ names for internals now). I have no objection to removing it, though. |
|||
| msg267510 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2016-06-06 02:30 | |
New changeset 2057b0af1c52 by Martin Panter in branch 'default': Issue #27108: Add missing names to mimetypes.__all__, by Jacek Kołodziej https://hg.python.org/cpython/rev/2057b0af1c52 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:31 | admin | set | github: 71295 |
| 2016-06-06 02:55:25 | martin.panter | set | status: open -> closed resolution: fixed stage: commit review -> resolved |
| 2016-06-06 02:30:54 | python-dev | set | nosy:
+ python-dev messages: + msg267510 |
| 2016-05-25 13:28:08 | r.david.murray | set | messages: + msg266348 |
| 2016-05-25 13:16:53 | martin.panter | link | issue23883 dependencies |
| 2016-05-25 10:41:30 | Unit03 | set | files:
+ mimetypes_all.v2.patch messages: + msg266329 |
| 2016-05-25 09:10:35 | martin.panter | set | nosy:
+ martin.panter messages: + msg266323 stage: commit review |
| 2016-05-24 20:53:38 | r.david.murray | set | nosy:
+ r.david.murray messages: + msg266274 |
| 2016-05-24 20:31:36 | Unit03 | create | |