Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary line in statistics.pvariance #71164

Closed
IanFoote mannequin opened this issue May 8, 2016 · 5 comments
Closed

Unnecessary line in statistics.pvariance #71164

IanFoote mannequin opened this issue May 8, 2016 · 5 comments
Labels
stdlib Python modules in the Lib dir

Comments

@IanFoote
Copy link
Mannequin

IanFoote mannequin commented May 8, 2016

BPO 26977
Nosy @stevendaprano

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2016-05-08.12:16:50.115>
created_at = <Date 2016-05-08.11:56:09.670>
labels = ['library']
title = 'Unnecessary line in statistics.pvariance'
updated_at = <Date 2016-05-11.03:01:58.951>
user = 'https://bugs.python.org/IanFoote'

bugs.python.org fields:

activity = <Date 2016-05-11.03:01:58.951>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2016-05-08.12:16:50.115>
closer = 'steven.daprano'
components = ['Library (Lib)']
creation = <Date 2016-05-08.11:56:09.670>
creator = 'Ian Foote'
dependencies = []
files = []
hgrepos = []
issue_num = 26977
keywords = []
message_count = 5.0
messages = ['265131', '265133', '265134', '265287', '265289']
nosy_count = 3.0
nosy_names = ['steven.daprano', 'python-dev', 'Ian Foote']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue26977'
versions = ['Python 3.6']
@IanFoote
Copy link
Mannequin Author

IanFoote mannequin commented May 8, 2016

In statistics.pvariance, the sum of squares helper function (_ss) is called twice and the first return value is unused:

cpython/Lib/statistics.py

Line 596 in 9043c80

ss = _ss(data, mu)

@IanFoote IanFoote mannequin added the stdlib Python modules in the Lib dir label May 8, 2016
@python-dev
Copy link
Mannequin

python-dev mannequin commented May 8, 2016

New changeset 2bf4a02f3570 by Steven D'Aprano in branch 'default':
bpo-26977, remove unneeded line in pvariance (duplicate call to _ss).
https://hg.python.org/cpython/rev/2bf4a02f3570

@stevendaprano
Copy link
Member

Thanks Ian! I can't believe I looked at that function earlier today and couldn't see that!

@python-dev
Copy link
Mannequin

python-dev mannequin commented May 11, 2016

New changeset 6f27dbc55f10 by Steven D'Aprano in branch '3.5':
bpo-26977, remove unneeded line in pvariance (duplicate call to _ss).
https://hg.python.org/cpython/rev/6f27dbc55f10

New changeset 3c75707045f5 by Steven D'Aprano in branch 'default':
Branch merge for bpo-26977
https://hg.python.org/cpython/rev/3c75707045f5

@python-dev
Copy link
Mannequin

python-dev mannequin commented May 11, 2016

New changeset 87130512ef34 by Steven D'Aprano in branch '3.5':
NEWS message for issue bpo-26977.
https://hg.python.org/cpython/rev/87130512ef34

New changeset 39faad3cd626 by Steven D'Aprano in branch 'default':
Merge NEWS update from 3.5 for issue bpo-26977.
https://hg.python.org/cpython/rev/39faad3cd626

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stdlib Python modules in the Lib dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stevendaprano