classification
Title: Unnecessary line in statistics.pvariance
Type: Stage: resolved
Components: Library (Lib) Versions: Python 3.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: Ian Foote, python-dev, steven.daprano
Priority: normal Keywords:

Created on 2016-05-08 11:56 by Ian Foote, last changed 2016-05-11 03:01 by python-dev. This issue is now closed.

Messages (5)
msg265131 - (view) Author: Ian Foote (Ian Foote) Date: 2016-05-08 11:56
In statistics.pvariance, the sum of squares helper function (_ss) is called twice and the first return value is unused: https://github.com/python/cpython/blob/9043c80b0daaddb5bff1e37432d503910506727f/Lib/statistics.py#L596
msg265133 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-05-08 12:14
New changeset 2bf4a02f3570 by Steven D'Aprano in branch 'default':
Issue 26977, remove unneeded line in pvariance (duplicate call to _ss).
https://hg.python.org/cpython/rev/2bf4a02f3570
msg265134 - (view) Author: Steven D'Aprano (steven.daprano) * (Python committer) Date: 2016-05-08 12:16
Thanks Ian! I can't believe I looked at that function earlier today and couldn't see that!
msg265287 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-05-11 01:53
New changeset 6f27dbc55f10 by Steven D'Aprano in branch '3.5':
Issue 26977, remove unneeded line in pvariance (duplicate call to _ss).
https://hg.python.org/cpython/rev/6f27dbc55f10

New changeset 3c75707045f5 by Steven D'Aprano in branch 'default':
Branch merge for issue 26977
https://hg.python.org/cpython/rev/3c75707045f5
msg265289 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-05-11 03:01
New changeset 87130512ef34 by Steven D'Aprano in branch '3.5':
NEWS message for issue #26977.
https://hg.python.org/cpython/rev/87130512ef34

New changeset 39faad3cd626 by Steven D'Aprano in branch 'default':
Merge NEWS update from 3.5 for issue #26977.
https://hg.python.org/cpython/rev/39faad3cd626
History
Date User Action Args
2016-05-11 03:01:58python-devsetmessages: + msg265289
2016-05-11 01:53:26python-devsetmessages: + msg265287
2016-05-08 12:29:11berker.peksagsetresolution: fixed
2016-05-08 12:16:50steven.dapranosetstatus: open -> closed

nosy: + steven.daprano
messages: + msg265134

stage: resolved
2016-05-08 12:14:57python-devsetnosy: + python-dev
messages: + msg265133
2016-05-08 11:56:09Ian Footecreate