Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use sys.platform instead of os.name in asyncio docs consistently #69722

Closed
4kir4 mannequin opened this issue Nov 2, 2015 · 3 comments
Closed

use sys.platform instead of os.name in asyncio docs consistently #69722

4kir4 mannequin opened this issue Nov 2, 2015 · 3 comments
Labels
topic-asyncio

Comments

@4kir4
Copy link
Mannequin

4kir4 mannequin commented Nov 2, 2015

BPO 25536
Nosy @gvanrossum, @vstinner, @4kir4, @1st1
Files
  • doc-asyncio-os.name->sys.platform.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2015-11-02.17:18:24.105>
created_at = <Date 2015-11-02.16:55:19.464>
labels = ['expert-asyncio']
title = 'use sys.platform instead of os.name in asyncio docs consistently'
updated_at = <Date 2015-11-02.17:18:24.103>
user = 'https://github.com/4kir4'

    bugs.python.org fields:

    activity = <Date 2015-11-02.17:18:24.103>
actor = 'gvanrossum'
assignee = 'none'
closed = True
closed_date = <Date 2015-11-02.17:18:24.105>
closer = 'gvanrossum'
components = ['asyncio']
creation = <Date 2015-11-02.16:55:19.464>
creator = 'akira'
dependencies = []
files = ['40930']
hgrepos = []
issue_num = 25536
keywords = ['patch']
message_count = 3.0
messages = ['253931', '253933', '253934']
nosy_count = 4.0
nosy_names = ['gvanrossum', 'vstinner', 'akira', 'yselivanov']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue25536'
versions = ['Python 3.4', 'Python 3.5', 'Python 3.6']
    @4kir4
    Copy link
    Mannequin Author

    4kir4 mannequin commented Nov 2, 2015

    asyncio code uses "sys.platform == 'win32'" to detect OS.
    asyncio docs use both os.name and sys.platform.

    As far as I can tell there is no *practical* difference
    between "os.name == 'nt" and "sys.platform == 'win32'"
    for choosing asyncio.ProactorEventLoop()

    I've attached a patch that replaces all os.name occurrences
    in asyncio docs with sys.platform.

    @4kir4 4kir4 mannequin added the topic-asyncio label Nov 2, 2015
    @gvanrossum
    Copy link
    Member

    Sounds good. I'll commit this.

    @gvanrossum
    Copy link
    Member

    Fixed in 3.4, 3.5, 3.6 by these commits: 193327cabbbc, e2400d5d67e7, 40ce5f4b8835.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    topic-asyncio
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @gvanrossum