classification
Title: use sys.platform instead of os.name in asyncio docs consistently
Type: Stage:
Components: asyncio Versions: Python 3.6, Python 3.4, Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: akira, gvanrossum, vstinner, yselivanov
Priority: normal Keywords: patch

Created on 2015-11-02 16:55 by akira, last changed 2015-11-02 17:18 by gvanrossum. This issue is now closed.

Files
File name Uploaded Description Edit
doc-asyncio-os.name->sys.platform.patch akira, 2015-11-02 16:55 review
Messages (3)
msg253931 - (view) Author: Akira Li (akira) * Date: 2015-11-02 16:55
asyncio code uses "sys.platform == 'win32'" to detect OS.
asyncio docs use both os.name and sys.platform.

As far as I can tell there is no *practical* difference
between "os.name == 'nt" and "sys.platform == 'win32'"
for choosing asyncio.ProactorEventLoop()

I've attached a patch that replaces all os.name occurrences
in asyncio docs with sys.platform.
msg253933 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2015-11-02 17:12
Sounds good. I'll commit this.
msg253934 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2015-11-02 17:18
Fixed in 3.4, 3.5, 3.6 by these commits: 193327cabbbc, e2400d5d67e7, 40ce5f4b8835.
History
Date User Action Args
2015-11-02 17:18:24gvanrossumsetstatus: open -> closed
resolution: fixed
messages: + msg253934
2015-11-02 17:12:26gvanrossumsetmessages: + msg253933
2015-11-02 16:55:19akiracreate