Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUILD_MAP stack effect suboptimal #69246

Closed
pitrou opened this issue Sep 10, 2015 · 2 comments
Closed

BUILD_MAP stack effect suboptimal #69246

pitrou opened this issue Sep 10, 2015 · 2 comments
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage

Comments

@pitrou
Copy link
Member

pitrou commented Sep 10, 2015

BPO 25060
Nosy @birkenfeld, @pitrou, @benjaminp

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2015-09-11.04:11:35.065>
created_at = <Date 2015-09-10.17:01:36.820>
labels = ['interpreter-core', 'performance']
title = 'BUILD_MAP stack effect suboptimal'
updated_at = <Date 2015-09-11.04:11:35.063>
user = 'https://github.com/pitrou'

bugs.python.org fields:

activity = <Date 2015-09-11.04:11:35.063>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2015-09-11.04:11:35.065>
closer = 'python-dev'
components = ['Interpreter Core']
creation = <Date 2015-09-10.17:01:36.820>
creator = 'pitrou'
dependencies = []
files = []
hgrepos = []
issue_num = 25060
keywords = []
message_count = 2.0
messages = ['250391', '250441']
nosy_count = 4.0
nosy_names = ['georg.brandl', 'pitrou', 'benjamin.peterson', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'resource usage'
url = 'https://bugs.python.org/issue25060'
versions = ['Python 3.5', 'Python 3.6']
@pitrou
Copy link
Member Author

pitrou commented Sep 10, 2015

In PyCompile_OpcodeStackEffect() compile.c:

    case BUILD_MAP:
        return 1;

But starting from 3.5, BUILD_MAP pops 2*oparg objects from the stack.

@pitrou pitrou added interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage labels Sep 10, 2015
@python-dev
Copy link
Mannequin

python-dev mannequin commented Sep 11, 2015

New changeset 6c1b0dd07340 by Benjamin Peterson in branch '3.5':
compute stack effect of BUILD_MAP correctly (closes bpo-25060)
https://hg.python.org/cpython/rev/6c1b0dd07340

New changeset 7d76df6dafde by Benjamin Peterson in branch 'default':
merge 3.5 (bpo-25060)
https://hg.python.org/cpython/rev/7d76df6dafde

@python-dev python-dev mannequin closed this as completed Sep 11, 2015
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pitrou