classification
Title: BUILD_MAP stack effect suboptimal
Type: resource usage Stage: resolved
Components: Interpreter Core Versions: Python 3.6, Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: benjamin.peterson, georg.brandl, pitrou, python-dev
Priority: normal Keywords:

Created on 2015-09-10 17:01 by pitrou, last changed 2015-09-11 04:11 by python-dev. This issue is now closed.

Messages (2)
msg250391 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2015-09-10 17:01
In PyCompile_OpcodeStackEffect() compile.c:

        case BUILD_MAP:
            return 1;

But starting from 3.5, BUILD_MAP pops 2*oparg objects from the stack.
msg250441 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2015-09-11 04:11
New changeset 6c1b0dd07340 by Benjamin Peterson in branch '3.5':
compute stack effect of BUILD_MAP correctly (closes #25060)
https://hg.python.org/cpython/rev/6c1b0dd07340

New changeset 7d76df6dafde by Benjamin Peterson in branch 'default':
merge 3.5 (#25060)
https://hg.python.org/cpython/rev/7d76df6dafde
History
Date User Action Args
2015-09-11 04:11:35python-devsetstatus: open -> closed

nosy: + python-dev
messages: + msg250441

resolution: fixed
stage: resolved
2015-09-10 17:01:36pitroucreate