Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

indentation fix in ceval.c in python 2.7 #69083

Closed
LaurentCoustet mannequin opened this issue Aug 19, 2015 · 6 comments
Closed

indentation fix in ceval.c in python 2.7 #69083

LaurentCoustet mannequin opened this issue Aug 19, 2015 · 6 comments
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@LaurentCoustet
Copy link
Mannequin

LaurentCoustet mannequin commented Aug 19, 2015

BPO 24895
Nosy @brettcannon, @pitrou, @benjaminp, @bitdancer
Files
  • cpython2.7_indentfix_ceval.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2015-08-20.03:39:00.038>
created_at = <Date 2015-08-19.10:01:43.956>
labels = ['interpreter-core']
title = 'indentation fix in ceval.c in python 2.7'
updated_at = <Date 2015-08-20.03:39:00.035>
user = 'https://bugs.python.org/LaurentCoustet'

    bugs.python.org fields:

    activity = <Date 2015-08-20.03:39:00.035>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2015-08-20.03:39:00.038>
closer = 'python-dev'
components = ['Interpreter Core']
creation = <Date 2015-08-19.10:01:43.956>
creator = 'Laurent Coustet'
dependencies = []
files = ['40212']
hgrepos = []
issue_num = 24895
keywords = ['patch']
message_count = 6.0
messages = ['248827', '248846', '248851', '248852', '248853', '248873']
nosy_count = 6.0
nosy_names = ['brett.cannon', 'pitrou', 'benjamin.peterson', 'r.david.murray', 'python-dev', 'Laurent Coustet']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue24895'
versions = ['Python 2.7']
    @LaurentCoustet
    Copy link
    Mannequin Author

    LaurentCoustet mannequin commented Aug 19, 2015

    https://hg.python.org/cpython/rev/17d3bbde60d2

    introduced a patch using tabs for indentation in ceval.c.

    Attached patch just make the code more consistent by using spaces instead of tabs for indentation.

    Related to: http://bugs.python.org/issue4753

    @LaurentCoustet LaurentCoustet mannequin added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Aug 19, 2015
    @brettcannon
    Copy link
    Member

    Thanks for the patch, Laurent.

    Can any other core devs remembered if we explicitly untabbed the C source in 2.7? I know we did in Python 3, but I can't remember if we did it in Python 2 to make patches easier.

    @bitdancer
    Copy link
    Member

    I couldn't remember either. Antoine should know, he did the work/commit.

    @LaurentCoustet
    Copy link
    Mannequin Author

    LaurentCoustet mannequin commented Aug 19, 2015

    by the way, the rest of the code did not contain any tab in ceval.c. They were added by 17d3bbde60d2

    @pitrou
    Copy link
    Member

    pitrou commented Aug 19, 2015

    The Python 3 code doesn't have tabs. I'm assuming Benjamin took the original patch instead of trying to backport the Python 3 commit.

    @vstinner vstinner changed the title indentation fix in ceval.c indentation fix in ceval.c in python 2.7 Aug 19, 2015
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Aug 20, 2015

    New changeset ea2f6fd04307 by Benjamin Peterson in branch '2.7':
    remove tabs from ceval.c (closes bpo-24895)
    https://hg.python.org/cpython/rev/ea2f6fd04307

    @python-dev python-dev mannequin closed this as completed Aug 20, 2015
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    interpreter-core (Objects, Python, Grammar, and Parser dirs)
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @brettcannon @bitdancer @pitrou