Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension modules with single-letter names can't be loaded #68516

Closed
encukou opened this issue May 29, 2015 · 4 comments
Closed

Extension modules with single-letter names can't be loaded #68516

encukou opened this issue May 29, 2015 · 4 comments
Labels
release-blocker type-bug An unexpected behavior, bug, or error

Comments

@encukou
Copy link
Member

encukou commented May 29, 2015

BPO 24328
Nosy @brettcannon, @ncoghlan, @encukou, @ericsnowcurrently, @vadmium
Files
  • fix-short-names.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2015-05-29.22:11:53.968>
created_at = <Date 2015-05-29.19:49:52.190>
labels = ['type-bug', 'release-blocker']
title = "Extension modules with single-letter names can't be loaded"
updated_at = <Date 2015-05-29.23:44:58.127>
user = 'https://github.com/encukou'

    bugs.python.org fields:

    activity = <Date 2015-05-29.23:44:58.127>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2015-05-29.22:11:53.968>
closer = 'python-dev'
components = []
creation = <Date 2015-05-29.19:49:52.190>
creator = 'petr.viktorin'
dependencies = []
files = ['39554']
hgrepos = []
issue_num = 24328
keywords = ['patch']
message_count = 4.0
messages = ['244403', '244424', '244430', '244431']
nosy_count = 6.0
nosy_names = ['brett.cannon', 'ncoghlan', 'petr.viktorin', 'python-dev', 'eric.snow', 'martin.panter']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue24328'
versions = ['Python 3.5', 'Python 3.6']
    @encukou
    Copy link
    Member Author

    encukou commented May 29, 2015

    A regression in the PEP-489 implementation prevents loading extension modules with single-character names (because length-1 bytestrings are interned).

    Here is a fix. It would be great to have it in 3.5.0b2.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented May 29, 2015

    New changeset 784f372d701a by Benjamin Peterson in branch '3.5':
    fix importing one char extension modules (closes bpo-24328)
    https://hg.python.org/cpython/rev/784f372d701a

    New changeset d89bab1f160e by Benjamin Peterson in branch 'default':
    merge 3.5 (bpo-24328)
    https://hg.python.org/cpython/rev/d89bab1f160e

    @python-dev python-dev mannequin closed this as completed May 29, 2015
    @vadmium
    Copy link
    Member

    vadmium commented May 29, 2015

    Two minor comments on Reitveld. Looks like you alreay fixed one of them in the actual commit.

    @vadmium vadmium added the type-bug An unexpected behavior, bug, or error label May 29, 2015
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented May 29, 2015

    New changeset 8428cb297d15 by Benjamin Peterson in branch '3.5':
    use assert method (bpo-24328)
    https://hg.python.org/cpython/rev/8428cb297d15

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    release-blocker type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @encukou @bitdancer @vadmium