Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a now-unnecessary workaround from importlib._bootstrap. #68508

Closed
ericsnowcurrently opened this issue May 28, 2015 · 9 comments
Closed

Remove a now-unnecessary workaround from importlib._bootstrap. #68508

ericsnowcurrently opened this issue May 28, 2015 · 9 comments
Assignees
@ericsnowcurrently
Labels
type-bug An unexpected behavior, bug, or error

Comments

@ericsnowcurrently
Copy link
Member

BPO 24320
Nosy @brettcannon, @ncoghlan, @larryhastings, @ericsnowcurrently, @dstufft
Files
  • issue24320-remove-hack.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ericsnowcurrently'
closed_at = <Date 2016-09-09.20:42:21.468>
created_at = <Date 2015-05-28.22:34:56.897>
labels = ['type-bug']
title = 'Remove a now-unnecessary workaround from importlib._bootstrap.'
updated_at = <Date 2016-09-09.20:42:21.467>
user = 'https://github.com/ericsnowcurrently'

    bugs.python.org fields:

    activity = <Date 2016-09-09.20:42:21.467>
actor = 'eric.snow'
assignee = 'eric.snow'
closed = True
closed_date = <Date 2016-09-09.20:42:21.468>
closer = 'eric.snow'
components = []
creation = <Date 2015-05-28.22:34:56.897>
creator = 'eric.snow'
dependencies = []
files = ['39599']
hgrepos = []
issue_num = 24320
keywords = ['patch']
message_count = 9.0
messages = ['244350', '244351', '244454', '244681', '244695', '244697', '244699', '244710', '275431']
nosy_count = 7.0
nosy_names = ['brett.cannon', 'ncoghlan', 'larry', 'Arfrever', 'python-dev', 'eric.snow', 'dstufft']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue24320'
versions = ['Python 3.6']
    @ericsnowcurrently
    Copy link
    Member Author

    In issue bpo-23911 I worked around a bug [1] in pkg_resources (setuptools) which caused test_venv to fail when I split out importlib._bootstrap_external. That bug has now been fixed so we just(?) need to update the version of pip we're bundling and remove the hack I put in as a workaround (see msg242440).

    [1] https://bitbucket.org/pypa/setuptools/issue/378

    @ericsnowcurrently ericsnowcurrently self-assigned this May 28, 2015
    @ericsnowcurrently
    Copy link
    Member Author

    Would we be okay fixing this in 3.5 as well? I ask because I'm not familiar with the constraints we have on what pip is bundled.

    @ncoghlan
    Copy link
    Contributor

    Donald updated 3.5 to pip 7 for the 1st beta, so the relevant fix may have already been included.

    @ericsnowcurrently
    Copy link
    Member Author

    https://hg.python.org/cpython/rev/5c4ba50f6a57

    I'll see if that does it.

    @larry, would you be opposed to dropping the hack for beta 3? That would mean just deleting the last 2 lines in Lib/importlib/_bootstrap_external.py.

    @larryhastings
    Copy link
    Contributor

    Sounds okay in theory. Is the bug in question now tested in our regression suite?

    @ericsnowcurrently
    Copy link
    Member Author

    Yep. test_venv failures is how I found the problem in the first place.

    @larryhastings
    Copy link
    Contributor

    Then you may fire when ready.

    @ericsnowcurrently
    Copy link
    Member Author

    Hmm. Looks like the fix in setuptools/pkg_resources is 17.0. [1] The bundled pip to which we just updated is 7.0.3, which appears to bundle pkg_resources 15.0. [2] So unless I've misunderstood, the hack will have to linger for a bit longer.

    Here's a patch for when we get there.

    [1] https://bitbucket.org/pypa/setuptools/commits/tag/17.0
    [2] https://github.com/pypa/pip/blob/7.0.3/pip/_vendor/README.rst

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Sep 9, 2016

    New changeset 821663556d87 by Eric Snow in branch 'default':
    Issue bpo-24320: Drop an old setuptools-induced hack.
    https://hg.python.org/cpython/rev/821663556d87

    @ericsnowcurrently ericsnowcurrently added the type-bug An unexpected behavior, bug, or error label Sep 9, 2016
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @ericsnowcurrently ericsnowcurrently

    Labels
    type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @ncoghlan @ericsnowcurrently @larryhastings