Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #23865 breaks docutils #68313

Closed
mitya57 mannequin opened this issue May 4, 2015 · 4 comments
Closed

Fix for #23865 breaks docutils #68313

mitya57 mannequin opened this issue May 4, 2015 · 4 comments
Labels
release-blocker stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@mitya57
Copy link
Mannequin

mitya57 mannequin commented May 4, 2015

BPO 24125
Nosy @goodger, @doko42, @larryhastings, @benjaminp, @serhiy-storchaka, @mitya57
Files
  • expatreader_keep_col_line.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2015-05-06.07:14:05.159>
created_at = <Date 2015-05-04.20:36:12.407>
labels = ['type-bug', 'library', 'release-blocker']
title = 'Fix for python/cpython#68053 breaks docutils'
updated_at = <Date 2015-05-06.07:14:05.158>
user = 'https://github.com/mitya57'

    bugs.python.org fields:

    activity = <Date 2015-05-06.07:14:05.158>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2015-05-06.07:14:05.159>
closer = 'serhiy.storchaka'
components = ['Library (Lib)']
creation = <Date 2015-05-04.20:36:12.407>
creator = 'mitya57'
dependencies = []
files = ['39290']
hgrepos = []
issue_num = 24125
keywords = ['patch']
message_count = 4.0
messages = ['242579', '242584', '242611', '242644']
nosy_count = 7.0
nosy_names = ['goodger', 'doko', 'larry', 'benjamin.peterson', 'python-dev', 'serhiy.storchaka', 'mitya57']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue24125'
versions = ['Python 2.7', 'Python 3.4', 'Python 3.5']
    @mitya57
    Copy link
    Mannequin Author

    mitya57 mannequin commented May 4, 2015

    Fix for issue bpo-23865 (i.e. https://hg.python.org/cpython/rev/f7ddec2e9e93 in 2.7 branch) introduced a change for xml.sax.expatreader.ExpatParser class that makes its close() method delete _parser object.

    This breaks docutils, which handles exceptions in parse() and tries to use getColumnNumber() after it fails. The log is available here: <http://mitya57.me/builds/python-docutils_0.12+dfsg-1_amd64.build\>.

    I believe that particular chunk should be reverted.

    @mitya57 mitya57 mannequin added the stdlib Python modules in the Lib dir label May 4, 2015
    @serhiy-storchaka
    Copy link
    Member

    Here is a patch that keeps error column and line after closing ExpatParser if error was occurred.

    @serhiy-storchaka serhiy-storchaka added the type-bug An unexpected behavior, bug, or error label May 4, 2015
    @mitya57
    Copy link
    Mannequin Author

    mitya57 mannequin commented May 5, 2015

    The patch fixes the issue, thanks Serhiy!

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented May 6, 2015

    New changeset fe340c2a220e by Serhiy Storchaka in branch '2.7':
    Issue bpo-24125: Saved error's line and column numbers when an error is occured
    https://hg.python.org/cpython/rev/fe340c2a220e

    New changeset 7f8cd879687b by Serhiy Storchaka in branch '3.4':
    Issue bpo-24125: Saved error's line and column numbers when an error is occured
    https://hg.python.org/cpython/rev/7f8cd879687b

    New changeset 1fb83fa2cdef by Serhiy Storchaka in branch 'default':
    Issue bpo-24125: Saved error's line and column numbers when an error is occured
    https://hg.python.org/cpython/rev/1fb83fa2cdef

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    release-blocker stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @serhiy-storchaka @doko42