This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Fix for #23865 breaks docutils
Type: behavior Stage: resolved
Components: Library (Lib) Versions: Python 3.4, Python 3.5, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: benjamin.peterson, doko, goodger, larry, mitya57, python-dev, serhiy.storchaka
Priority: release blocker Keywords: patch

Created on 2015-05-04 20:36 by mitya57, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
expatreader_keep_col_line.patch serhiy.storchaka, 2015-05-04 21:40 review
Messages (4)
msg242579 - (view) Author: Dmitry Shachnev (mitya57) * Date: 2015-05-04 20:36
Fix for issue #23865 (i.e. https://hg.python.org/cpython/rev/f7ddec2e9e93 in 2.7 branch) introduced a change for xml.sax.expatreader.ExpatParser class that makes its close() method delete _parser object.

This breaks docutils, which handles exceptions in parse() and tries to use getColumnNumber() after it fails. The log is available here: <http://mitya57.me/builds/python-docutils_0.12+dfsg-1_amd64.build>.

I believe that particular chunk should be reverted.
msg242584 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2015-05-04 21:40
Here is a patch that keeps error column and line after closing ExpatParser if error was occurred.
msg242611 - (view) Author: Dmitry Shachnev (mitya57) * Date: 2015-05-05 19:11
The patch fixes the issue, thanks Serhiy!
msg242644 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2015-05-06 06:54
New changeset fe340c2a220e by Serhiy Storchaka in branch '2.7':
Issue #24125: Saved error's line and column numbers when an error is occured
https://hg.python.org/cpython/rev/fe340c2a220e

New changeset 7f8cd879687b by Serhiy Storchaka in branch '3.4':
Issue #24125: Saved error's line and column numbers when an error is occured
https://hg.python.org/cpython/rev/7f8cd879687b

New changeset 1fb83fa2cdef by Serhiy Storchaka in branch 'default':
Issue #24125: Saved error's line and column numbers when an error is occured
https://hg.python.org/cpython/rev/1fb83fa2cdef
History
Date User Action Args
2022-04-11 14:58:16adminsetgithub: 68313
2015-05-06 07:14:05serhiy.storchakasetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2015-05-06 06:54:24python-devsetnosy: + python-dev
messages: + msg242644
2015-05-05 19:11:10mitya57setmessages: + msg242611
2015-05-04 21:40:04serhiy.storchakasetfiles: + expatreader_keep_col_line.patch
versions: + Python 3.5
messages: + msg242584

keywords: + patch
type: behavior
stage: patch review
2015-05-04 20:43:23mitya57setnosy: + larry

versions: + Python 3.4
2015-05-04 20:40:01dokosetpriority: normal -> release blocker
nosy: + benjamin.peterson
2015-05-04 20:36:12mitya57create