Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert os._getfullpathname() and os._isdir() to Argument Clinic #68230

Closed
serhiy-storchaka opened this issue Apr 23, 2015 · 6 comments
Closed

Convert os._getfullpathname() and os._isdir() to Argument Clinic #68230

serhiy-storchaka opened this issue Apr 23, 2015 · 6 comments
Labels
OS-windows topic-argument-clinic type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

BPO 24042
Nosy @loewis, @larryhastings, @tjguk, @zware, @serhiy-storchaka, @zooba
Files
  • clinic_os_getfullpathname.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2015-05-13.06:46:10.189>
created_at = <Date 2015-04-23.19:01:02.834>
labels = ['type-feature', 'expert-argument-clinic', 'OS-windows']
title = 'Convert os._getfullpathname() and os._isdir() to Argument Clinic'
updated_at = <Date 2015-05-13.06:46:10.188>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2015-05-13.06:46:10.188>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2015-05-13.06:46:10.189>
closer = 'serhiy.storchaka'
components = ['Windows', 'Argument Clinic']
creation = <Date 2015-04-23.19:01:02.834>
creator = 'serhiy.storchaka'
dependencies = []
files = ['39187']
hgrepos = []
issue_num = 24042
keywords = ['patch']
message_count = 6.0
messages = ['241878', '241880', '241881', '242958', '243022', '243046']
nosy_count = 7.0
nosy_names = ['loewis', 'larry', 'tim.golden', 'BreamoreBoy', 'zach.ware', 'serhiy.storchaka', 'steve.dower']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue24042'
versions = ['Python 3.5']
    @serhiy-storchaka
    Copy link
    Member Author

    Proposed patch converts os._getfullpathname() and os._isdir() to Argument Clinic. This simplifies a code and as a sided effect adds a check for embedded null character in os._getfullpathname(). The patch is not tested and can contain bugs.

    @larryhastings
    Copy link
    Contributor

    Why isn't the patch tested?

    @serhiy-storchaka
    Copy link
    Member Author

    I have no Windows.

    @serhiy-storchaka
    Copy link
    Member Author

    Could anyone please test the patch on Windows?

    @BreamoreBoy
    Copy link
    Mannequin

    BreamoreBoy mannequin commented May 12, 2015

    I've tested the patch on Windows 8.1, 32 and 64 bit release and debug builds with no problems.

    @serhiy-storchaka
    Copy link
    Member Author

    Committed in 4d7175af607e. Thank you Mark for the testing.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    OS-windows topic-argument-clinic type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @serhiy-storchaka @larryhastings