This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: Convert os._getfullpathname() and os._isdir() to Argument Clinic
Type: enhancement Stage: resolved
Components: Argument Clinic, Windows Versions: Python 3.5
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: BreamoreBoy, larry, loewis, serhiy.storchaka, steve.dower, tim.golden, zach.ware
Priority: normal Keywords: patch

Created on 2015-04-23 19:01 by serhiy.storchaka, last changed 2022-04-11 14:58 by admin. This issue is now closed.

File name Uploaded Description Edit
clinic_os_getfullpathname.patch serhiy.storchaka, 2015-04-23 19:01 review
Messages (6)
msg241878 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2015-04-23 19:01
Proposed patch converts os._getfullpathname() and os._isdir() to Argument Clinic. This simplifies a code and as a sided effect adds a check for embedded null character in os._getfullpathname(). The patch is not tested and can contain bugs.
msg241880 - (view) Author: Larry Hastings (larry) * (Python committer) Date: 2015-04-23 19:04
Why isn't the patch tested?
msg241881 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2015-04-23 19:34
I have no Windows.
msg242958 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2015-05-12 10:53
Could anyone please test the patch on Windows?
msg243022 - (view) Author: Mark Lawrence (BreamoreBoy) * Date: 2015-05-12 21:39
I've tested the patch on Windows 8.1, 32 and 64 bit release and debug builds with no problems.
msg243046 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2015-05-13 06:46
Committed in 4d7175af607e. Thank you Mark for the testing.
Date User Action Args
2022-04-11 14:58:16adminsetgithub: 68230
2015-05-13 06:46:10serhiy.storchakasetstatus: open -> closed
resolution: fixed
messages: + msg243046

stage: patch review -> resolved
2015-05-12 21:39:02BreamoreBoysetnosy: + BreamoreBoy
messages: + msg243022
2015-05-12 10:53:47serhiy.storchakasetmessages: + msg242958
2015-04-23 19:34:53serhiy.storchakasetmessages: + msg241881
2015-04-23 19:04:23larrysetmessages: + msg241880
2015-04-23 19:01:39serhiy.storchakasetfiles: + clinic_os_getfullpathname.patch
keywords: + patch
2015-04-23 19:01:19serhiy.storchakalinkissue24009 dependencies
2015-04-23 19:01:02serhiy.storchakacreate