Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add git support to make patchcheck #68219

Closed
tiran opened this issue Apr 22, 2015 · 4 comments
Closed

Add git support to make patchcheck #68219

tiran opened this issue Apr 22, 2015 · 4 comments
Labels
build The build process and cross-build type-feature A feature request or enhancement

Comments

@tiran
Copy link
Member

tiran commented Apr 22, 2015

BPO 24031
Nosy @tiran, @berkerpeksag
Files
  • patchcheck_git.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2015-04-23.09:26:32.746>
created_at = <Date 2015-04-22.20:29:35.493>
labels = ['type-feature', 'build']
title = 'Add git support to make patchcheck'
updated_at = <Date 2015-04-23.09:26:32.745>
user = 'https://github.com/tiran'

    bugs.python.org fields:

    activity = <Date 2015-04-23.09:26:32.745>
actor = 'christian.heimes'
assignee = 'none'
closed = True
closed_date = <Date 2015-04-23.09:26:32.746>
closer = 'christian.heimes'
components = ['Build']
creation = <Date 2015-04-22.20:29:35.493>
creator = 'christian.heimes'
dependencies = []
files = ['39174']
hgrepos = []
issue_num = 24031
keywords = ['patch']
message_count = 4.0
messages = ['241824', '241840', '241856', '241857']
nosy_count = 3.0
nosy_names = ['christian.heimes', 'python-dev', 'berker.peksag']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue24031'
versions = ['Python 3.4', 'Python 3.5']
    @tiran
    Copy link
    Member Author

    tiran commented Apr 22, 2015

    'make patchcheck' supports only Mercurial checkouts. The tool uses the 'hg status' command to find modified files. My patch implements 'git status' support in order to make the patch check tool available on git checkouts.

    @tiran tiran added build The build process and cross-build type-feature A feature request or enhancement labels Apr 22, 2015
    @berkerpeksag
    Copy link
    Member

    LGTM

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Apr 23, 2015

    New changeset 0f9c43fb189d by Christian Heimes in branch '3.4':
    Issue bpo-24031: make patchcheck now supports git checkouts, too.
    https://hg.python.org/cpython/rev/0f9c43fb189d

    New changeset d1b706e57fbe by Christian Heimes in branch 'default':
    Issue bpo-24031: make patchcheck now supports git checkouts, too.
    https://hg.python.org/cpython/rev/d1b706e57fbe

    @tiran
    Copy link
    Member Author

    tiran commented Apr 23, 2015

    Thanks!

    @tiran tiran closed this as completed Apr 23, 2015
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    build The build process and cross-build type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @berkerpeksag @tiran