Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patchcheck doesn't depend on all #67773

Closed
rbtcollins opened this issue Mar 4, 2015 · 3 comments
Closed

patchcheck doesn't depend on all #67773

rbtcollins opened this issue Mar 4, 2015 · 3 comments
Labels
build The build process and cross-build interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@rbtcollins
Copy link
Member

BPO 23585
Nosy @ncoghlan, @rbtcollins
Files
  • patchcheck.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2015-03-16.02:33:44.584>
created_at = <Date 2015-03-04.23:35:49.529>
labels = ['interpreter-core', 'build']
title = "patchcheck doesn't depend on all"
updated_at = <Date 2015-03-16.02:33:44.583>
user = 'https://github.com/rbtcollins'

    bugs.python.org fields:

    activity = <Date 2015-03-16.02:33:44.583>
actor = 'rbcollins'
assignee = 'none'
closed = True
closed_date = <Date 2015-03-16.02:33:44.584>
closer = 'rbcollins'
components = ['Interpreter Core']
creation = <Date 2015-03-04.23:35:49.529>
creator = 'rbcollins'
dependencies = []
files = ['38334']
hgrepos = []
issue_num = 23585
keywords = ['patch']
message_count = 3.0
messages = ['237221', '238176', '238178']
nosy_count = 3.0
nosy_names = ['ncoghlan', 'rbcollins', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue23585'
versions = ['Python 3.6']
    @rbtcollins
    Copy link
    Member Author

    make patchcheck depends on the interpreter and modules being built to work correctly but the make target doesn't have this expressed. This simple patch will fix it and adds well under a second of latency for me.

    cpython.hg$ make patchcheck
./python ./Tools/scripts/patchcheck.py
Could not find platform dependent libraries <exec_prefix>
Consider setting $PYTHONHOME to <prefix>[:<exec_prefix>]
Failed to import the site module
Traceback (most recent call last):
  File "/home/robertc/work/cpython.hg/Lib/site.py", line 555, in <module>
    main()
  File "/home/robertc/work/cpython.hg/Lib/site.py", line 541, in main
    known_paths = addusersitepackages(known_paths)
  File "/home/robertc/work/cpython.hg/Lib/site.py", line 281, in addusersitepackages
    user_site = getusersitepackages()
  File "/home/robertc/work/cpython.hg/Lib/site.py", line 257, in getusersitepackages
    user_base = getuserbase() # this will also set USER_BASE
  File "/home/robertc/work/cpython.hg/Lib/site.py", line 247, in getuserbase
    USER_BASE = get_config_var('userbase')
  File "/home/robertc/work/cpython.hg/Lib/sysconfig.py", line 582, in get_config_var
    return get_config_vars().get(name)
  File "/home/robertc/work/cpython.hg/Lib/sysconfig.py", line 531, in get_config_vars
    _init_posix(_CONFIG_VARS)
  File "/home/robertc/work/cpython.hg/Lib/sysconfig.py", line 403, in _init_posix
    from _sysconfigdata import build_time_vars
ImportError: No module named '_sysconfigdata'
Makefile:1640: recipe for target 'patchcheck' failed
make: *** [patchcheck] Error 1

    @rbtcollins rbtcollins added interpreter-core (Objects, Python, Grammar, and Parser dirs) build The build process and cross-build labels Mar 4, 2015
    @ncoghlan
    Copy link
    Contributor

    Sounds fine to me.

    This could be particularly useful for docs-only patches, where you may not have done a local "make test" first.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Mar 16, 2015

    New changeset de093a1ec51b by Robert Collins in branch 'default':
    Issue bpo-23585: make patchcheck will ensure the interpreter is built.
    https://hg.python.org/cpython/rev/de093a1ec51b

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    build The build process and cross-build interpreter-core (Objects, Python, Grammar, and Parser dirs)
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @rbtcollins @ncoghlan