classification
Title: patchcheck doesn't depend on all
Type: compile error Stage:
Components: Interpreter Core Versions: Python 3.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: ncoghlan, python-dev, rbcollins
Priority: normal Keywords: patch

Created on 2015-03-04 23:35 by rbcollins, last changed 2015-03-16 02:33 by rbcollins. This issue is now closed.

Files
File name Uploaded Description Edit
patchcheck.patch rbcollins, 2015-03-04 23:35 review
Messages (3)
msg237221 - (view) Author: Robert Collins (rbcollins) * (Python committer) Date: 2015-03-04 23:35
make patchcheck depends on the interpreter and modules being built to work correctly but the make target doesn't have this expressed. This simple patch will fix it and adds well under a second of latency for me.

cpython.hg$ make patchcheck
./python ./Tools/scripts/patchcheck.py
Could not find platform dependent libraries <exec_prefix>
Consider setting $PYTHONHOME to <prefix>[:<exec_prefix>]
Failed to import the site module
Traceback (most recent call last):
  File "/home/robertc/work/cpython.hg/Lib/site.py", line 555, in <module>
    main()
  File "/home/robertc/work/cpython.hg/Lib/site.py", line 541, in main
    known_paths = addusersitepackages(known_paths)
  File "/home/robertc/work/cpython.hg/Lib/site.py", line 281, in addusersitepackages
    user_site = getusersitepackages()
  File "/home/robertc/work/cpython.hg/Lib/site.py", line 257, in getusersitepackages
    user_base = getuserbase() # this will also set USER_BASE
  File "/home/robertc/work/cpython.hg/Lib/site.py", line 247, in getuserbase
    USER_BASE = get_config_var('userbase')
  File "/home/robertc/work/cpython.hg/Lib/sysconfig.py", line 582, in get_config_var
    return get_config_vars().get(name)
  File "/home/robertc/work/cpython.hg/Lib/sysconfig.py", line 531, in get_config_vars
    _init_posix(_CONFIG_VARS)
  File "/home/robertc/work/cpython.hg/Lib/sysconfig.py", line 403, in _init_posix
    from _sysconfigdata import build_time_vars
ImportError: No module named '_sysconfigdata'
Makefile:1640: recipe for target 'patchcheck' failed
make: *** [patchcheck] Error 1
msg238176 - (view) Author: Nick Coghlan (ncoghlan) * (Python committer) Date: 2015-03-16 02:25
Sounds fine to me.

This could be particularly useful for docs-only patches, where you may not have done a local "make test" first.
msg238178 - (view) Author: Roundup Robot (python-dev) Date: 2015-03-16 02:30
New changeset de093a1ec51b by Robert Collins in branch 'default':
Issue #23585: make patchcheck will ensure the interpreter is built.
https://hg.python.org/cpython/rev/de093a1ec51b
History
Date User Action Args
2015-03-16 02:33:44rbcollinssetstatus: open -> closed
resolution: fixed
2015-03-16 02:30:45python-devsetnosy: + python-dev
messages: + msg238178
2015-03-16 02:25:04ncoghlansetnosy: + ncoghlan
messages: + msg238176
2015-03-04 23:35:49rbcollinscreate