Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation warnings building 3.5 Visual Studio Windows 8.1 64 bit #67639

Closed
BreamoreBoy mannequin opened this issue Feb 11, 2015 · 12 comments
Closed

Deprecation warnings building 3.5 Visual Studio Windows 8.1 64 bit #67639

BreamoreBoy mannequin opened this issue Feb 11, 2015 · 12 comments
Labels
3.7 (EOL) end of life build The build process and cross-build OS-windows

Comments

@BreamoreBoy
Copy link
Mannequin

BreamoreBoy mannequin commented Feb 11, 2015

BPO 23451
Nosy @pitrou, @vstinner, @tjguk, @zware, @zooba, @miss-islington
PRs
  • bpo-23451: Fix socket deprecation warnings in socketmodule.c #2318
  • bpo-23451: Update time.monotonic() documentation #11190
  • [3.7] bpo-23451: Update time.monotonic() documentation (GH-11190) #11191
    		•
    Files
  • Deprecations.txt
  • 23451_1.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-08-02.22:25:29.281>
created_at = <Date 2015-02-11.23:34:06.308>
labels = ['build', '3.7', 'OS-windows']
title = 'Deprecation warnings building 3.5 Visual Studio Windows 8.1 64 bit'
updated_at = <Date 2019-08-02.22:25:29.280>
user = 'https://bugs.python.org/BreamoreBoy'

    bugs.python.org fields:

    activity = <Date 2019-08-02.22:25:29.280>
actor = 'steve.dower'
assignee = 'none'
closed = True
closed_date = <Date 2019-08-02.22:25:29.281>
closer = 'steve.dower'
components = ['Build', 'Windows']
creation = <Date 2015-02-11.23:34:06.308>
creator = 'BreamoreBoy'
dependencies = []
files = ['38101', '38103']
hgrepos = []
issue_num = 23451
keywords = ['patch']
message_count = 12.0
messages = ['235778', '235781', '235786', '235789', '236645', '237055', '237056', '239401', '297224', '297231', '331982', '331989']
nosy_count = 7.0
nosy_names = ['pitrou', 'vstinner', 'tim.golden', 'python-dev', 'zach.ware', 'steve.dower', 'miss-islington']
pr_nums = ['2318', '11190', '11191']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue23451'
versions = ['Python 3.7']
    @BreamoreBoy
    Copy link
    Mannequin Author

    BreamoreBoy mannequin commented Feb 11, 2015

    Raised as a placeholder.

    @BreamoreBoy BreamoreBoy mannequin added build The build process and cross-build OS-windows labels Feb 11, 2015
    @BreamoreBoy
    Copy link
    Mannequin Author

    BreamoreBoy mannequin commented Feb 11, 2015

    Using Microsoft Visual Studio Express 2013 for Windows Desktop.

    @zooba
    Copy link
    Member

    zooba commented Feb 12, 2015

    Adding 'socket' nosy list, as Antoine may have a stronger opinion about changing _socket to avoid these warnings - they aren't all in Windows-exclusive code. Or I'm happy to add the suppression to the build if that's the better option.

    I'll work up a patch for the GetVersion deprecations. I believe they're mostly checking for Vista, which we can assume now, so they aren't necessary.

    @zooba
    Copy link
    Member

    zooba commented Feb 12, 2015

    Patch attached.

    Interesting, once you declare Vista as the minimum API set, WinSock claims to support CMSG_LEN which enables sendmsg() et al support in _socket. Since the WinSock API bears little relation to the POSIX(?) API, it doesn't build, so I've just undef'd CMSG_LEN when building socket.

    @zooba
    Copy link
    Member

    zooba commented Feb 26, 2015

    Anyone got a chance to double-check my patch for me? I think it's fine, unless someone really wants me to turn all the "#ifdef CMSG_LEN" checks into "#ifdef HAVE_CMSG" (which I *think* would require autoconf updates, which I am totally unqualified to do...)

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Mar 2, 2015

    New changeset 57e2549cc9a6 by Steve Dower in branch 'default':
    Issue bpo-23451: Update pyconfig.h for Windows to require Vista headers and remove unnecessary version checks.
    https://hg.python.org/cpython/rev/57e2549cc9a6

    @zooba
    Copy link
    Member

    zooba commented Mar 2, 2015

    The _WINSOCK_DEPRECATED_NO_WARNINGS question is still open, but the rest of the deprecations should be clear now.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Mar 27, 2015

    New changeset f64d0b99d405 by Victor Stinner in branch 'default':
    Issue bpo-23451, bpo-22117: Python 3.5 now requires Windows Vista or newer, so
    https://hg.python.org/cpython/rev/f64d0b99d405

    @zooba
    Copy link
    Member

    zooba commented Jun 28, 2017

    New changeset 9f3bdcb by Steve Dower (Segev Finer) in branch 'master':
    bpo-23451: Fix socket deprecation warnings in socketmodule.c (bpo-2318)
    9f3bdcb

    @zooba
    Copy link
    Member

    zooba commented Jun 28, 2017

    There is only one deprecation warning left in current builds:

    ..\Modules\expat\xmlparse.c(796): warning C4996: 'getenv': This function or variable may be unsafe. Consider using _dupenv_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.

    @zooba zooba added the 3.7 (EOL) end of life label Jun 28, 2017
    @vstinner
    Copy link
    Member

    New changeset 3ab064e by Victor Stinner in branch 'master':
    bpo-23451: Update time.monotonic() documentation (GH-11190)
    3ab064e

    @miss-islington
    Copy link
    Contributor

    New changeset c367d52 by Miss Islington (bot) in branch '3.7':
    bpo-23451: Update time.monotonic() documentation (GH-11190)
    c367d52

    @zooba zooba closed this as completed Aug 2, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life build The build process and cross-build OS-windows
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @vstinner @zooba @miss-islington