Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make profile-opt: test_distutils failure #67579

Closed
skrah mannequin opened this issue Feb 3, 2015 · 3 comments
Closed

make profile-opt: test_distutils failure #67579

skrah mannequin opened this issue Feb 3, 2015 · 3 comments
Assignees
@gpshead
Labels
type-bug An unexpected behavior, bug, or error

Comments

@skrah
Copy link
Mannequin

skrah mannequin commented Feb 3, 2015

BPO 23390
Nosy @gpshead, @skrah
Files
  • issue23390.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/gpshead'
closed_at = <Date 2015-02-04.10:31:08.330>
created_at = <Date 2015-02-03.23:44:57.143>
labels = ['type-bug']
title = 'make profile-opt: test_distutils failure'
updated_at = <Date 2015-02-04.10:31:08.329>
user = 'https://github.com/skrah'

    bugs.python.org fields:

    activity = <Date 2015-02-04.10:31:08.329>
actor = 'gregory.p.smith'
assignee = 'gregory.p.smith'
closed = True
closed_date = <Date 2015-02-04.10:31:08.330>
closer = 'gregory.p.smith'
components = []
creation = <Date 2015-02-03.23:44:57.143>
creator = 'skrah'
dependencies = []
files = ['38009']
hgrepos = []
issue_num = 23390
keywords = ['patch']
message_count = 3.0
messages = ['235367', '235370', '235383']
nosy_count = 3.0
nosy_names = ['gregory.p.smith', 'skrah', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue23390'
versions = []
    @skrah skrah mannequin added the type-bug An unexpected behavior, bug, or error label Feb 3, 2015
    @skrah
    Copy link
    Mannequin Author

    skrah mannequin commented Feb 3, 2015

    Currently -fprofile-use etc. appear in the distutils CFLAGS, which
    causes test_distutils to fail.

    @gpshead
    Copy link
    Member

    gpshead commented Feb 4, 2015

    Likely a dupe of http://bugs.python.org/issue22904 which is why i set the buildbot up. :)

    I like your patch here better than my non-fixing poor hack in the other issue. I hadn't noticed CFLAGS_NODIST before.

    @gpshead gpshead self-assigned this Feb 4, 2015
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Feb 4, 2015

    New changeset 8957ff9776bd by Gregory P. Smith in branch '3.4':
    Fixes bpo-23390: make profile-opt causes -fprofile-generate and related flags
    https://hg.python.org/cpython/rev/8957ff9776bd

    New changeset 9c46707e5526 by Gregory P. Smith in branch 'default':
    Fixes bpo-23390: make profile-opt causes -fprofile-generate and related flags
    https://hg.python.org/cpython/rev/9c46707e5526

    @gpshead gpshead closed this as completed Feb 4, 2015
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @gpshead gpshead

    Labels
    type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @gpshead