Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_ssl.c cannot be compiled with older versions of OpenSSL #67524

Closed
ned-deily opened this issue Jan 28, 2015 · 2 comments
Closed

_ssl.c cannot be compiled with older versions of OpenSSL #67524

ned-deily opened this issue Jan 28, 2015 · 2 comments

Comments

@ned-deily
Copy link
Member

BPO 23335
Nosy @benjaminp, @ned-deily

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2015-01-28.17:07:23.359>
created_at = <Date 2015-01-28.04:21:26.040>
labels = []
title = '_ssl.c cannot be compiled with older versions of OpenSSL'
updated_at = <Date 2015-01-28.17:07:23.357>
user = 'https://github.com/ned-deily'

bugs.python.org fields:

activity = <Date 2015-01-28.17:07:23.357>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2015-01-28.17:07:23.359>
closer = 'python-dev'
components = []
creation = <Date 2015-01-28.04:21:26.040>
creator = 'ned.deily'
dependencies = []
files = []
hgrepos = []
issue_num = 23335
keywords = []
message_count = 2.0
messages = ['234871', '234904']
nosy_count = 4.0
nosy_names = ['benjamin.peterson', 'ned.deily', 'Arfrever', 'python-dev']
pr_nums = []
priority = 'critical'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue23335'
versions = ['Python 2.7', 'Python 3.5']
@ned-deily
Copy link
Member Author

_ssl.c compilation is broken on default and 27 when building with older (pre-1.0.1 ?) versions of OpenSSL:

/py/dev/3x/source/Modules/_ssl.c:2296:24: error: use of undeclared identifier
'OPENSSL_NPN_NEGOTIATED'
if (alpn && ret != OPENSSL_NPN_NEGOTIATED)

The code added by eaa38b75cc78 (default) and 94ec4d8cf104 (2.7) doesn't account for the possibility that NPN is not available. (The Snow Leopard buildbots are down at the moment but I would expect them to be failing with this.)

@python-dev
Copy link
Mannequin

python-dev mannequin commented Jan 28, 2015

New changeset 16f982f93a47 by Benjamin Peterson in branch 'default':
ifdef our way to compatibility with old openssl (closes bpo-23335)
https://hg.python.org/cpython/rev/16f982f93a47

New changeset 1addc4f0f10c by Benjamin Peterson in branch '2.7':
ifdef our way to compatibility with old openssl (closes bpo-23335)
https://hg.python.org/cpython/rev/1addc4f0f10c

@python-dev python-dev mannequin closed this as completed Jan 28, 2015
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ned-deily