Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible error in _header_value_parser.py #67336

Closed
serhiy-storchaka opened this issue Jan 2, 2015 · 8 comments
Closed

Possible error in _header_value_parser.py #67336

serhiy-storchaka opened this issue Jan 2, 2015 · 8 comments
Labels
3.7 (EOL) end of life stdlib Python modules in the Lib dir topic-email type-bug An unexpected behavior, bug, or error

Comments

@serhiy-storchaka
Copy link
Member

BPO 23147
Nosy @warsaw, @bitdancer, @serhiy-storchaka, @isidentical

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2020-01-07.18:33:10.257>
created_at = <Date 2015-01-02.10:31:19.047>
labels = ['3.7', 'type-bug', 'library', 'expert-email']
title = 'Possible error in _header_value_parser.py'
updated_at = <Date 2020-01-07.18:33:10.254>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2020-01-07.18:33:10.254>
actor = 'r.david.murray'
assignee = 'none'
closed = True
closed_date = <Date 2020-01-07.18:33:10.257>
closer = 'r.david.murray'
components = ['Library (Lib)', 'email']
creation = <Date 2015-01-02.10:31:19.047>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 23147
keywords = []
message_count = 8.0
messages = ['233309', '235891', '236362', '236363', '236364', '270629', '359460', '359532']
nosy_count = 5.0
nosy_names = ['barry', 'r.david.murray', 'python-dev', 'serhiy.storchaka', 'BTaskaya']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue23147'
versions = ['Python 3.5', 'Python 3.6', 'Python 3.7']
@serhiy-storchaka
Copy link
Member Author

In UnstructuredTokenList._fold() at line 439 the fold() method is called with one positional argument.

            if part.has_fws:
                part.fold(folded)
                continue

But there are no fold() methods with one positional parameter. May be it should be _fold()?

@serhiy-storchaka serhiy-storchaka added stdlib Python modules in the Lib dir topic-email type-bug An unexpected behavior, bug, or error labels Jan 2, 2015
@serhiy-storchaka
Copy link
Member Author

Ping.

@bitdancer
Copy link
Member

Probably. What I need is a test case that triggers it. (FYI, I know there are other bugs in that algorithm...what I really need to do is completely rewrite it to be simpler and more understandable, but there are so many edge cases that I haven't found the time to tackle it yet).

@serhiy-storchaka
Copy link
Member Author

If I had a test case, I would write the patch. But I'm not experienced in the email package.

@bitdancer
Copy link
Member

Yes, I assumed that you didn't have a test case. I was explaining why I hadn't done anything with this issue :)

@python-dev
Copy link
Mannequin

python-dev mannequin commented Jul 17, 2016

New changeset efd4ffa88173 by Serhiy Storchaka in branch '3.5':
Issues bpo-23147, bpo-23148: Presumably fixed bugs in folding UnstructuredTokenList.
https://hg.python.org/cpython/rev/efd4ffa88173

New changeset 33593fcdf8b0 by Serhiy Storchaka in branch 'default':
Issues bpo-23147, bpo-23148: Presumably fixed bugs in folding UnstructuredTokenList.
https://hg.python.org/cpython/rev/33593fcdf8b0

@serhiy-storchaka serhiy-storchaka added the 3.7 (EOL) end of life label Sep 14, 2016
@isidentical
Copy link
Sponsor Member

This issue looks resolved.

@bitdancer
Copy link
Member

Thanks for the ping. Whether or not Serhiy's patch fixed the original problem, the algorithm rewrite has happened so this issue is no longer relevant in any case.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.7 (EOL) end of life stdlib Python modules in the Lib dir topic-email type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bitdancer @serhiy-storchaka @isidentical