This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Possible error in _header_value_parser.py
Type: behavior Stage: resolved
Components: email, Library (Lib) Versions: Python 3.7, Python 3.6, Python 3.5
process
Status: closed Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: BTaskaya, barry, python-dev, r.david.murray, serhiy.storchaka
Priority: normal Keywords:

Created on 2015-01-02 10:31 by serhiy.storchaka, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Messages (8)
msg233309 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2015-01-02 10:31
In UnstructuredTokenList._fold() at line 439 the fold() method is called with one positional argument.

            if part.has_fws:
                part.fold(folded)
                continue

But there are no fold() methods with one positional parameter. May be it should be _fold()?
msg235891 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2015-02-13 14:28
Ping.
msg236362 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2015-02-21 14:29
Probably.  What I need is a test case that triggers it.  (FYI, I know there are other bugs in that algorithm...what I really need to do is completely rewrite it to be simpler and more understandable, but there are so many edge cases that I haven't found the time to tackle it yet).
msg236363 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2015-02-21 14:35
If I had a test case, I would write the patch. But I'm not experienced in the email package.
msg236364 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2015-02-21 14:39
Yes, I assumed that you didn't have a test case.  I was explaining why I hadn't done anything with this issue :)
msg270629 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-07-17 10:26
New changeset efd4ffa88173 by Serhiy Storchaka in branch '3.5':
Issues #23147, #23148: Presumably fixed bugs in folding UnstructuredTokenList.
https://hg.python.org/cpython/rev/efd4ffa88173

New changeset 33593fcdf8b0 by Serhiy Storchaka in branch 'default':
Issues #23147, #23148: Presumably fixed bugs in folding UnstructuredTokenList.
https://hg.python.org/cpython/rev/33593fcdf8b0
msg359460 - (view) Author: Batuhan Taskaya (BTaskaya) * (Python committer) Date: 2020-01-06 19:45
This issue looks resolved.
msg359532 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2020-01-07 18:33
Thanks for the ping.  Whether or not Serhiy's patch fixed the original problem, the algorithm rewrite has happened so this issue is no longer relevant in any case.
History
Date User Action Args
2022-04-11 14:58:11adminsetgithub: 67336
2020-01-07 18:33:10r.david.murraysetstatus: open -> closed

messages: + msg359532
stage: test needed -> resolved
2020-01-06 19:45:05BTaskayasetnosy: + BTaskaya
messages: + msg359460
2016-09-14 13:44:25serhiy.storchakasetstage: test needed
versions: + Python 3.6, Python 3.7, - Python 3.4
2016-07-17 10:26:32python-devsetnosy: + python-dev
messages: + msg270629
2015-02-21 14:39:52r.david.murraysetmessages: + msg236364
2015-02-21 14:35:09serhiy.storchakasetmessages: + msg236363
2015-02-21 14:29:25r.david.murraysetmessages: + msg236362
2015-02-13 14:28:24serhiy.storchakasetmessages: + msg235891
2015-01-02 10:31:19serhiy.storchakacreate