Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[regression] Lib/ssl.py still references _ssl.sslwrap #66713

Closed
doko42 opened this issue Sep 30, 2014 · 7 comments
Closed

[regression] Lib/ssl.py still references _ssl.sslwrap #66713

doko42 opened this issue Sep 30, 2014 · 7 comments
Labels
release-blocker stdlib Python modules in the Lib dir

Comments

@doko42
Copy link
Member

doko42 commented Sep 30, 2014

BPO 22523
Nosy @doko42, @pitrou, @giampaolo, @tiran, @benjaminp, @alex, @dstufft
Files
  • issue22523.diff
  • issue22523.diff
  • issue22523.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2014-10-02.03:54:03.661>
created_at = <Date 2014-09-30.12:50:55.991>
labels = ['library', 'release-blocker']
title = '[regression] Lib/ssl.py still references _ssl.sslwrap'
updated_at = <Date 2014-10-02.03:54:03.660>
user = 'https://github.com/doko42'

    bugs.python.org fields:

    activity = <Date 2014-10-02.03:54:03.660>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2014-10-02.03:54:03.661>
closer = 'python-dev'
components = ['Library (Lib)']
creation = <Date 2014-09-30.12:50:55.991>
creator = 'doko'
dependencies = []
files = ['36770', '36771', '36775']
hgrepos = []
issue_num = 22523
keywords = ['patch', 'needs review']
message_count = 7.0
messages = ['227896', '227899', '228129', '228131', '228132', '228150', '228156']
nosy_count = 9.0
nosy_names = ['doko', 'janssen', 'pitrou', 'giampaolo.rodola', 'christian.heimes', 'benjamin.peterson', 'alex', 'python-dev', 'dstufft']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue22523'
versions = ['Python 2.7']
    @doko42
    Copy link
    Member Author

    doko42 commented Sep 30, 2014

    the backport in issue bpo-21308 caused this regression. _ssl.sslwrap is still referenced in some files.

    @doko42 doko42 added release-blocker stdlib Python modules in the Lib dir labels Sep 30, 2014
    @doko42
    Copy link
    Member Author

    doko42 commented Sep 30, 2014

    forwarded from https://bugs.debian.org/762010

    @alex
    Copy link
    Member

    alex commented Oct 1, 2014

    Attached patch sound fix the issue. I guess this function has no tests :-(

    @alex
    Copy link
    Member

    alex commented Oct 1, 2014

    My patch is incomplete, I'm working on an improved one.

    @alex
    Copy link
    Member

    alex commented Oct 1, 2014

    New patch resolves the issue. Turns out there were tests, but they weren't being run. Now they are.

    @alex
    Copy link
    Member

    alex commented Oct 2, 2014

    Updated patch fixes a refcounting issue spotted by gutworth.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 2, 2014

    New changeset 1a36d4e8cf4e by Benjamin Peterson in branch '2.7':
    fix sslwrap_simple (closes bpo-22523)
    https://hg.python.org/cpython/rev/1a36d4e8cf4e

    @python-dev python-dev mannequin closed this as completed Oct 2, 2014
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    release-blocker stdlib Python modules in the Lib dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @alex @doko42