Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup.py check - should fail and retrun a non 0 exit code #65608

Closed
dundeemt mannequin opened this issue May 1, 2014 · 3 comments
Closed

setup.py check - should fail and retrun a non 0 exit code #65608

dundeemt mannequin opened this issue May 1, 2014 · 3 comments
Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@dundeemt
Copy link
Mannequin

dundeemt mannequin commented May 1, 2014

BPO 21409
Nosy @merwok, @zooba, @dstufft

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2021-02-03.18:29:02.788>
created_at = <Date 2014-05-01.20:07:11.679>
labels = ['type-bug', 'library']
title = 'setup.py check - should fail and retrun a non 0 exit code'
updated_at = <Date 2021-02-03.18:29:02.787>
user = 'https://bugs.python.org/dundeemt'

bugs.python.org fields:

activity = <Date 2021-02-03.18:29:02.787>
actor = 'steve.dower'
assignee = 'none'
closed = True
closed_date = <Date 2021-02-03.18:29:02.788>
closer = 'steve.dower'
components = ['Distutils']
creation = <Date 2014-05-01.20:07:11.679>
creator = 'dundeemt'
dependencies = []
files = []
hgrepos = []
issue_num = 21409
keywords = []
message_count = 3.0
messages = ['217719', '217720', '386404']
nosy_count = 4.0
nosy_names = ['eric.araujo', 'steve.dower', 'dstufft', 'dundeemt']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue21409'
versions = ['Python 3.1', 'Python 2.7', 'Python 3.2', 'Python 3.3', 'Python 3.4', 'Python 3.5']
@dundeemt
Copy link
Mannequin Author

dundeemt mannequin commented May 1, 2014

python setup.py check
python setup.py check --restructuredtext

both incorrectly "warn" and don't "Fail" for things that will cause a failure when uploading to pypi. This is wrong.

Additionally, they should return a non 0 exit code so they can be used as part of an CI such as drone.io / travis so the build will show as failing. Currently they do not, and if there are errors that will cause a pypi failure (like an unreadable long description) bad things happen.

@dundeemt dundeemt mannequin added stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels May 1, 2014
@dundeemt
Copy link
Mannequin Author

dundeemt mannequin commented May 1, 2014

example:

(dhp)jlh@jlh-d520:/Projects/dhp/src$ python setup.py check
running check
(dhp)jlh@jlh-d520:/Projects/dhp/src$ python setup.py check --restructuredtext
running check
warning: check: Title underline too short. (line 2)

warning: check: Could not finish the parsing.

@zooba
Copy link
Member

zooba commented Feb 3, 2021

Distutils is now deprecated (see PEP-632) and all tagged issues are being closed. From now until removal, only release blocking issues will be considered for distutils.

If this issue does not relate to distutils, please remove the component and reopen it. If you believe it still requires a fix, most likely the issue should be re-reported at https://github.com/pypa/setuptools

@zooba zooba closed this as completed Feb 3, 2021
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zooba