classification
Title: setup.py check - should fail and retrun a non 0 exit code
Type: behavior Stage: resolved
Components: Distutils Versions: Python 3.1, Python 3.2, Python 3.3, Python 3.4, Python 3.5, Python 2.7
process
Status: closed Resolution: out of date
Dependencies: Superseder:
Assigned To: Nosy List: dstufft, dundeemt, eric.araujo, steve.dower
Priority: normal Keywords:

Created on 2014-05-01 20:07 by dundeemt, last changed 2021-02-03 18:29 by steve.dower. This issue is now closed.

Messages (3)
msg217719 - (view) Author: Jeff Hinrichs (dundeemt) Date: 2014-05-01 20:07
python setup.py check 
python setup.py check --restructuredtext

both incorrectly "warn" and don't "Fail" for things that will cause a failure when uploading to pypi.  This is wrong.

Additionally, they should return a non 0 exit code so they can be used as part of an CI such as drone.io / travis so the build will show as failing.  Currently they do not, and if there are errors that will cause a pypi failure (like an unreadable long description) bad things happen.
msg217720 - (view) Author: Jeff Hinrichs (dundeemt) Date: 2014-05-01 20:08
example:

(dhp)jlh@jlh-d520:~/Projects/dhp/src$ python setup.py check
running check
(dhp)jlh@jlh-d520:~/Projects/dhp/src$ python setup.py check --restructuredtext
running check
warning: check: Title underline too short. (line 2)

warning: check: Could not finish the parsing.
msg386404 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2021-02-03 18:29
Distutils is now deprecated (see PEP 632) and all tagged issues are being closed. From now until removal, only release blocking issues will be considered for distutils.

If this issue does not relate to distutils, please remove the component and reopen it. If you believe it still requires a fix, most likely the issue should be re-reported at https://github.com/pypa/setuptools
History
Date User Action Args
2021-02-03 18:29:02steve.dowersetstatus: open -> closed

nosy: + steve.dower
messages: + msg386404

resolution: out of date
stage: resolved
2014-05-01 20:08:35dundeemtsetmessages: + msg217720
2014-05-01 20:07:11dundeemtcreate