Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on all tests in test.test_importlib.source.test_file_loader #64998

Closed
brettcannon opened this issue Feb 27, 2014 · 3 comments
Closed

Turn on all tests in test.test_importlib.source.test_file_loader #64998

brettcannon opened this issue Feb 27, 2014 · 3 comments
Assignees
@brettcannon
Labels
easy stdlib Python modules in the Lib dir

Comments

@brettcannon
Copy link
Member

BPO 20799
Nosy @brettcannon, @matheusportela

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/brettcannon'
closed_at = <Date 2014-03-05.20:24:17.293>
created_at = <Date 2014-02-27.16:46:44.286>
labels = ['easy', 'invalid', 'library']
title = 'Turn on all tests in test.test_importlib.source.test_file_loader'
updated_at = <Date 2014-03-05.20:24:17.292>
user = 'https://github.com/brettcannon'

bugs.python.org fields:

activity = <Date 2014-03-05.20:24:17.292>
actor = 'brett.cannon'
assignee = 'brett.cannon'
closed = True
closed_date = <Date 2014-03-05.20:24:17.293>
closer = 'brett.cannon'
components = ['Library (Lib)']
creation = <Date 2014-02-27.16:46:44.286>
creator = 'brett.cannon'
dependencies = []
files = []
hgrepos = []
issue_num = 20799
keywords = ['easy']
message_count = 3.0
messages = ['212367', '212766', '212768']
nosy_count = 2.0
nosy_names = ['brett.cannon', 'matheus.v.portela']
pr_nums = []
priority = 'normal'
resolution = 'not a bug'
stage = 'needs patch'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue20799'
versions = ['Python 3.5']
@brettcannon
Copy link
Member Author

Some tests have a leading underscore which means they were probably turned off for testing purposes but forgot to be flipped back on. Should turn them back on and make sure that they actually still pass.

@brettcannon brettcannon self-assigned this Feb 27, 2014
@brettcannon brettcannon added stdlib Python modules in the Lib dir easy labels Feb 27, 2014
@matheusportela
Copy link
Mannequin

matheusportela mannequin commented Mar 5, 2014

Apparently, the methods with leading underscore are being tested by two classes (SourceLoaderBadBytecodeTest and SourcelessLoaderBadBytecodeTest) that implement methods with similar names (but without the underscore).

Simply removing the underscore breaks the tests since they cannot differ between the methods with and without underscore.

@brettcannon
Copy link
Member Author

Thanks for checking, Matheus! Closing this as invalid then.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brettcannon brettcannon

Labels
easy stdlib Python modules in the Lib dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brettcannon