New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle pip 1.5.3 in Python 3.4rc2 #64769
Comments
Larry, we currently have 0.15.2 bundled for 3.4rc1. This is the latest release of pip: http://www.pip-installer.org/en/latest/news.html#changelog However, there are a few additional fixes that have been merged to the pip 1.5.X maintenance branch that could be included in a 0.15.3 release:
It would be good to get those resolved prior to the final 3.4 release. |
Donald also pointed out that we want the fix to make pip complain if it is passed a wheel 2.0+ file (it's currently missing the version number warnings/errors that are called for in PEP-427). That isn't merged yet upstream, but will be part of 0.15.3. I interpreted Larry's comments on IRC as in-principle approval, so passing this to Donald to resolve (3.4rc2 is scheduled for February 23rd). |
Just t be clear, it's 1.5.3 not 0.15.3. |
Oops - 0.15.3 was the version of Beaker we just released, so my brain keeps confusing the two numbers :) |
Nick et al, currently trying b3 and using the bundled pip (1.5.2) to update the bundled setuptools from 2.1 to 2.2 on Windows 7 and I get the following. Any idea if this is still an issue with the newer versions (and thus might be relevant to this case)? F:\Python34>Scripts\pip3.4.exe install -U setuptools Cleaning up...
Exception:
Traceback (most recent call last):
File "F:\Python34\lib\site-packages\pip\basecommand.py", line 122, in main
status = self.run(options, args)
File "F:\Python34\lib\site-packages\pip\commands\install.py", line 274, in run
requirement_set.prepare_files(finder, force_root_egg_info=self.bundle, bundle=self.bundle)
File "F:\Python34\lib\site-packages\pip\req.py", line 1206, in prepare_files
for subreq in dist.requires(req_to_install.extras):
File "F:\Python34\lib\site-packages\pip\_vendor\pkg_resources.py", line 2232, in requires
dm = self._dep_map
File "F:\Python34\lib\site-packages\pip\_vendor\pkg_resources.py", line 2423, in _dep_map
self.__dep_map = self._compute_dependencies()
File "F:\Python34\lib\site-packages\pip\_vendor\pkg_resources.py", line 2445, in _compute_dependencies
for req in self._parsed_pkg_info.get_all('Requires-Dist') or []:
File "F:\Python34\lib\site-packages\pip\_vendor\pkg_resources.py", line 2415, in _parsed_pkg_info
self._pkg_info = Parser().parsestr(self.get_metadata(self.PKG_INFO))
File "F:\Python34\lib\email\parser.py", line 70, in parsestr
return self.parse(StringIO(text), headersonly=headersonly)
File "F:\Python34\lib\email\parser.py", line 60, in parse
return feedparser.close()
File "F:\Python34\lib\email\feedparser.py", line 170, in close
self._call_parse()
File "F:\Python34\lib\email\feedparser.py", line 163, in _call_parse
self._parse()
File "F:\Python34\lib\email\feedparser.py", line 449, in _parsegen
self._cur.set_payload(EMPTYSTRING.join(lines))
File "F:\Python34\lib\email\message.py", line 311, in set_payload
" payload") from None
TypeError: charset argument must be specified when non-ASCII characters are used in the payload Storing debug log for failure in C:\Users\asmodai\pip\pip.log |
I believe that may be an actual bug in the 3.4b3 email module (especially |
Yes, looks like it is just the email module: F:\Python33>Scripts\pip3.3.exe install -U setuptools Installing collected packages: setuptools I'll check rc1 when it's released by Larry and file as needed. Thanks for verifying. |
Yes, that issue was fixed on Friday. It is *possible* the fix still has a problem though, since the code in question is still different from that in 3.3.3. |
Just to confirm that I, indeed, did not run into problems any more with RC1 trying to upgrade setuptools. |
Donald, since you haven't been through an RC period before - just a reminder that Larry is going to need time to cherry pick the update into the release clone before rc2 on the 23rd. |
Yea, I'll get it done. Was planning on doing it this weekend but I had a medical issue. I'll see about getting all the things get done asap. |
I put out the email that I'll be rolling 1.5.3 tues/weds of next week (so 18th or 19th). Hopefully that's a reasonable time schedule. |
When you land this fix, please create the separate "3.4 cherry-pick" issue. Those issues are helping me a lot with keeping track of everything. |
Just a FYI I'm going to be cutting this release sometime in the next 6-12 hours and I'll commit it to the CPython repository and make the cherry-pick request. |
I created bpo-20713 |
My understanding is this is now done. If it isn't please reopen. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: