Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle pip 1.5.3 in Python 3.4rc2 #64769

Closed
ncoghlan opened this issue Feb 9, 2014 · 16 comments
Closed

Bundle pip 1.5.3 in Python 3.4rc2 #64769

ncoghlan opened this issue Feb 9, 2014 · 16 comments
Assignees
Labels
release-blocker type-bug An unexpected behavior, bug, or error

Comments

@ncoghlan
Copy link
Contributor

ncoghlan commented Feb 9, 2014

BPO 20570
Nosy @pfmoore, @ncoghlan, @larryhastings, @ashemedai, @bitdancer, @dstufft

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/dstufft'
closed_at = <Date 2014-02-23.07:07:37.475>
created_at = <Date 2014-02-09.04:20:15.844>
labels = ['type-bug', 'release-blocker']
title = 'Bundle pip 1.5.3 in Python 3.4rc2'
updated_at = <Date 2014-02-23.07:07:37.474>
user = 'https://github.com/ncoghlan'

bugs.python.org fields:

activity = <Date 2014-02-23.07:07:37.474>
actor = 'larry'
assignee = 'dstufft'
closed = True
closed_date = <Date 2014-02-23.07:07:37.475>
closer = 'larry'
components = []
creation = <Date 2014-02-09.04:20:15.844>
creator = 'ncoghlan'
dependencies = []
files = []
hgrepos = []
issue_num = 20570
keywords = []
message_count = 16.0
messages = ['210717', '210720', '210721', '210722', '210756', '210785', '210792', '210793', '211314', '211318', '211333', '211343', '211447', '211683', '211788', '211981']
nosy_count = 7.0
nosy_names = ['paul.moore', 'ncoghlan', 'larry', 'asmodai', 'r.david.murray', 'dstufft', 'Marcus.Smith']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue20570'
versions = ['Python 3.4']

@ncoghlan
Copy link
Contributor Author

ncoghlan commented Feb 9, 2014

Larry, we currently have 0.15.2 bundled for 3.4rc1. This is the latest release of pip: http://www.pip-installer.org/en/latest/news.html#changelog

However, there are a few additional fixes that have been merged to the pip 1.5.X maintenance branch that could be included in a 0.15.3 release:

  • the workaround to resolve bpo-20053 on Windows
  • a number of fixes related to wheel downloads
  • ensuring hash fragments in URLs are checked properly

It would be good to get those resolved prior to the final 3.4 release.

@ncoghlan ncoghlan added deferred-blocker type-bug An unexpected behavior, bug, or error labels Feb 9, 2014
@ncoghlan
Copy link
Contributor Author

ncoghlan commented Feb 9, 2014

Donald also pointed out that we want the fix to make pip complain if it is passed a wheel 2.0+ file (it's currently missing the version number warnings/errors that are called for in PEP-427). That isn't merged yet upstream, but will be part of 0.15.3.

I interpreted Larry's comments on IRC as in-principle approval, so passing this to Donald to resolve (3.4rc2 is scheduled for February 23rd).

@ncoghlan ncoghlan assigned dstufft and unassigned larryhastings Feb 9, 2014
@dstufft
Copy link
Member

dstufft commented Feb 9, 2014

Just t be clear, it's 1.5.3 not 0.15.3.

@ncoghlan
Copy link
Contributor Author

ncoghlan commented Feb 9, 2014

Oops - 0.15.3 was the version of Beaker we just released, so my brain keeps confusing the two numbers :)

@ncoghlan ncoghlan changed the title Bundle pip 0.15.3 in Python 3.4rc2 Bundle pip 1.5.3 in Python 3.4rc2 Feb 9, 2014
@ashemedai
Copy link
Mannequin

ashemedai mannequin commented Feb 9, 2014

Nick et al,

currently trying b3 and using the bundled pip (1.5.2) to update the bundled setuptools from 2.1 to 2.2 on Windows 7 and I get the following. Any idea if this is still an issue with the newer versions (and thus might be relevant to this case)?

F:\Python34>Scripts\pip3.4.exe install -U setuptools
Downloading/unpacking setuptools from https://pypi.python.org/packages/3.4/s/setuptools/setuptools-2.2-py2.py3-none-any.whl#md5=3b7d84f496aed8c07b91efba4aa197a4

Cleaning up...
Exception:
Traceback (most recent call last):
  File "F:\Python34\lib\site-packages\pip\basecommand.py", line 122, in main
    status = self.run(options, args)
  File "F:\Python34\lib\site-packages\pip\commands\install.py", line 274, in run
    requirement_set.prepare_files(finder, force_root_egg_info=self.bundle, bundle=self.bundle)
  File "F:\Python34\lib\site-packages\pip\req.py", line 1206, in prepare_files
    for subreq in dist.requires(req_to_install.extras):
  File "F:\Python34\lib\site-packages\pip\_vendor\pkg_resources.py", line 2232, in requires
    dm = self._dep_map
  File "F:\Python34\lib\site-packages\pip\_vendor\pkg_resources.py", line 2423, in _dep_map
    self.__dep_map = self._compute_dependencies()
  File "F:\Python34\lib\site-packages\pip\_vendor\pkg_resources.py", line 2445, in _compute_dependencies
    for req in self._parsed_pkg_info.get_all('Requires-Dist') or []:
  File "F:\Python34\lib\site-packages\pip\_vendor\pkg_resources.py", line 2415, in _parsed_pkg_info
    self._pkg_info = Parser().parsestr(self.get_metadata(self.PKG_INFO))
  File "F:\Python34\lib\email\parser.py", line 70, in parsestr
    return self.parse(StringIO(text), headersonly=headersonly)
  File "F:\Python34\lib\email\parser.py", line 60, in parse
    return feedparser.close()
  File "F:\Python34\lib\email\feedparser.py", line 170, in close
    self._call_parse()
  File "F:\Python34\lib\email\feedparser.py", line 163, in _call_parse
    self._parse()
  File "F:\Python34\lib\email\feedparser.py", line 449, in _parsegen
    self._cur.set_payload(EMPTYSTRING.join(lines))
  File "F:\Python34\lib\email\message.py", line 311, in set_payload
    " payload") from None
TypeError: charset argument must be specified when non-ASCII characters are used in the payload

Storing debug log for failure in C:\Users\asmodai\pip\pip.log

@ncoghlan
Copy link
Contributor Author

ncoghlan commented Feb 9, 2014

I believe that may be an actual bug in the 3.4b3 email module (especially
if pip 1.5.2 behaves itself in 3.3). If you can reproduce the error with
the default branch (or rc1 when it's available), please file a new issue
(with me, Larry and R. David Murray on the nosy list). If it doesn't happen
with rc1,then I would assume it was caused by one of the 3.4 email issues
that David fixed recently.

@ashemedai
Copy link
Mannequin

ashemedai mannequin commented Feb 9, 2014

Yes, looks like it is just the email module:

F:\Python33>Scripts\pip3.3.exe install -U setuptools
Downloading/unpacking setuptools from https://pypi.python.org/packages/3.4/s/setuptools/setuptools-2.2-py2.py3-none-any.whl#md5=3b7d84f496aed8c07b91efba4aa197a4

Installing collected packages: setuptools
Found existing installation: setuptools 2.1
Uninstalling setuptools:
Successfully uninstalled setuptools
Successfully installed setuptools
Cleaning up...

I'll check rc1 when it's released by Larry and file as needed. Thanks for verifying.

@bitdancer
Copy link
Member

Yes, that issue was fixed on Friday. It is *possible* the fix still has a problem though, since the code in question is still different from that in 3.3.3.

@ashemedai
Copy link
Mannequin

ashemedai mannequin commented Feb 16, 2014

Just to confirm that I, indeed, did not run into problems any more with RC1 trying to upgrade setuptools.

@ncoghlan
Copy link
Contributor Author

Donald, since you haven't been through an RC period before - just a reminder that Larry is going to need time to cherry pick the update into the release clone before rc2 on the 23rd.

@dstufft
Copy link
Member

dstufft commented Feb 16, 2014

Yea, I'll get it done. Was planning on doing it this weekend but I had a medical issue. I'll see about getting all the things get done asap.

@dstufft
Copy link
Member

dstufft commented Feb 16, 2014

I put out the email that I'll be rolling 1.5.3 tues/weds of next week (so 18th or 19th). Hopefully that's a reasonable time schedule.

@larryhastings
Copy link
Contributor

When you land this fix, please create the separate "3.4 cherry-pick" issue. Those issues are helping me a lot with keeping track of everything.

@dstufft
Copy link
Member

dstufft commented Feb 20, 2014

Just a FYI I'm going to be cutting this release sometime in the next 6-12 hours and I'll commit it to the CPython repository and make the cherry-pick request.

@dstufft
Copy link
Member

dstufft commented Feb 21, 2014

I created bpo-20713

@larryhastings
Copy link
Contributor

My understanding is this is now done. If it isn't please reopen.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-blocker type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

4 participants