Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use specific asserts in lib2to3 tests #63791

Closed
serhiy-storchaka opened this issue Nov 14, 2013 · 6 comments
Closed

Use specific asserts in lib2to3 tests #63791

serhiy-storchaka opened this issue Nov 14, 2013 · 6 comments
Assignees
@serhiy-storchaka
Labels
tests Tests in the Lib/test dir topic-2to3 type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

BPO 19592
Nosy @benjaminp, @serhiy-storchaka
Files
  • test_lib2to3_asserts.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2013-11-14.21:55:14.275>
created_at = <Date 2013-11-14.20:53:52.582>
labels = ['tests', 'type-feature', 'expert-2to3']
title = 'Use specific asserts in lib2to3 tests'
updated_at = <Date 2013-11-14.21:55:14.273>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2013-11-14.21:55:14.273>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2013-11-14.21:55:14.275>
closer = 'serhiy.storchaka'
components = ['Tests', '2to3 (2.x to 3.x conversion tool)']
creation = <Date 2013-11-14.20:53:52.582>
creator = 'serhiy.storchaka'
dependencies = []
files = ['32621']
hgrepos = []
issue_num = 19592
keywords = ['patch']
message_count = 6.0
messages = ['202884', '202888', '202891', '202893', '202898', '202899']
nosy_count = 3.0
nosy_names = ['benjamin.peterson', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue19592'
versions = ['Python 2.7', 'Python 3.3', 'Python 3.4']
    @serhiy-storchaka
    Copy link
    Member Author

    The proposed patch makes the lib2to3 package tests use more specific asserts. This will provide more useful failure report.

    @serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir topic-2to3 type-feature A feature request or enhancement labels Nov 14, 2013
    @benjaminp
    Copy link
    Contributor

    lgtm

    @serhiy-storchaka
    Copy link
    Member Author

    Should the patch be applied in maintenance releases?

    @benjaminp
    Copy link
    Contributor

    If you want.

    2013/11/14 Serhiy Storchaka <report@bugs.python.org>:

    Serhiy Storchaka added the comment:

    Should the patch be applied in maintenance releases?

    ----------

    Python tracker <report@bugs.python.org>
    <http://bugs.python.org/issue19592\>

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Nov 14, 2013

    New changeset c178d72e2f84 by Serhiy Storchaka in branch '2.7':
    Issue bpo-19592: Use specific asserts in lib2to3 tests.
    http://hg.python.org/cpython/rev/c178d72e2f84

    New changeset 46fc4fb2c8c5 by Serhiy Storchaka in branch '3.3':
    Issue bpo-19592: Use specific asserts in lib2to3 tests.
    http://hg.python.org/cpython/rev/46fc4fb2c8c5

    New changeset 1b9d8be8b07e by Serhiy Storchaka in branch 'default':
    Issue bpo-19592: Use specific asserts in lib2to3 tests.
    http://hg.python.org/cpython/rev/1b9d8be8b07e

    @serhiy-storchaka
    Copy link
    Member Author

    It will be easier to backport fixes if tests are consistent.

    @serhiy-storchaka serhiy-storchaka self-assigned this Nov 14, 2013
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @serhiy-storchaka serhiy-storchaka

    Labels
    tests Tests in the Lib/test dir topic-2to3 type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @benjaminp @serhiy-storchaka