classification
Title: Use specific asserts in lib2to3 tests
Type: enhancement Stage: resolved
Components: 2to3 (2.x to 3.x conversion tool), Tests Versions: Python 3.3, Python 3.4, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: serhiy.storchaka Nosy List: benjamin.peterson, python-dev, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2013-11-14 20:53 by serhiy.storchaka, last changed 2013-11-14 21:55 by serhiy.storchaka. This issue is now closed.

Files
File name Uploaded Description Edit
test_lib2to3_asserts.patch serhiy.storchaka, 2013-11-14 20:53 review
Messages (6)
msg202884 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2013-11-14 20:53
The proposed patch makes the lib2to3 package tests use more specific asserts. This will provide more useful failure report.
msg202888 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2013-11-14 21:11
lgtm
msg202891 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2013-11-14 21:13
Should the patch be applied in maintenance releases?
msg202893 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2013-11-14 21:16
If you want.

2013/11/14 Serhiy Storchaka <report@bugs.python.org>:
>
> Serhiy Storchaka added the comment:
>
> Should the patch be applied in maintenance releases?
>
> ----------
>
> _______________________________________
> Python tracker <report@bugs.python.org>
> <http://bugs.python.org/issue19592>
> _______________________________________
msg202898 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-11-14 21:51
New changeset c178d72e2f84 by Serhiy Storchaka in branch '2.7':
Issue #19592: Use specific asserts in lib2to3 tests.
http://hg.python.org/cpython/rev/c178d72e2f84

New changeset 46fc4fb2c8c5 by Serhiy Storchaka in branch '3.3':
Issue #19592: Use specific asserts in lib2to3 tests.
http://hg.python.org/cpython/rev/46fc4fb2c8c5

New changeset 1b9d8be8b07e by Serhiy Storchaka in branch 'default':
Issue #19592: Use specific asserts in lib2to3 tests.
http://hg.python.org/cpython/rev/1b9d8be8b07e
msg202899 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2013-11-14 21:55
It will be easier to backport fixes if tests are consistent.
History
Date User Action Args
2013-11-14 21:55:14serhiy.storchakasetstatus: open -> closed
versions: + Python 2.7, Python 3.3
messages: + msg202899

assignee: serhiy.storchaka
resolution: fixed
stage: patch review -> resolved
2013-11-14 21:51:07python-devsetnosy: + python-dev
messages: + msg202898
2013-11-14 21:16:30benjamin.petersonsetmessages: + msg202893
2013-11-14 21:13:14serhiy.storchakasetmessages: + msg202891
2013-11-14 21:11:27benjamin.petersonsetmessages: + msg202888
2013-11-14 21:02:18serhiy.storchakalinkissue16510 dependencies
2013-11-14 20:53:52serhiy.storchakacreate