Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lib/bsddb/test/test_thread.py uses old 'except' syntax #46248

Closed
orivej mannequin opened this issue Jan 28, 2008 · 7 comments
Closed

Lib/bsddb/test/test_thread.py uses old 'except' syntax #46248

orivej mannequin opened this issue Jan 28, 2008 · 7 comments
Assignees
@tiran
Labels
build The build process and cross-build stdlib Python modules in the Lib dir

Comments

@orivej
Copy link
Mannequin

orivej mannequin commented Jan 28, 2008

BPO 1956
Nosy @gvanrossum, @tiran, @orivej

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/tiran'
closed_at = <Date 2008-01-28.18:37:42.960>
created_at = <Date 2008-01-28.14:40:57.133>
labels = ['build', 'library']
title = "Lib/bsddb/test/test_thread.py uses old 'except' syntax"
updated_at = <Date 2008-01-28.18:37:42.958>
user = 'https://github.com/orivej'

bugs.python.org fields:

activity = <Date 2008-01-28.18:37:42.958>
actor = 'christian.heimes'
assignee = 'christian.heimes'
closed = True
closed_date = <Date 2008-01-28.18:37:42.960>
closer = 'christian.heimes'
components = ['Library (Lib)']
creation = <Date 2008-01-28.14:40:57.133>
creator = 'orivej'
dependencies = []
files = []
hgrepos = []
issue_num = 1956
keywords = []
message_count = 7.0
messages = ['61777', '61778', '61779', '61786', '61790', '61793', '61794']
nosy_count = 3.0
nosy_names = ['gvanrossum', 'christian.heimes', 'orivej']
pr_nums = []
priority = 'high'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue1956'
versions = ['Python 3.0']
@orivej
Copy link
Mannequin Author

orivej mannequin commented Jan 28, 2008

"except OSError, e:"
(appears twice) should be changed to
"except OSError as e:"

@orivej orivej mannequin added stdlib Python modules in the Lib dir build The build process and cross-build labels Jan 28, 2008
@orivej
Copy link
Mannequin Author

orivej mannequin commented Jan 28, 2008

Appeared in 60350 svnmerge:
http://svn.python.org/view/python/branches/py3k/Lib/bsddb/test/test_thread.py?rev=60350&view=log
http://svn.python.org/view/python/branches/py3k/Lib/bsddb/test/test_thread.py?rev=60350&r1=58058&r2=60350

@orivej
Copy link
Mannequin Author

orivej mannequin commented Jan 28, 2008

If you notice that at
http://svn.python.org/view/python/branches/py3k/Lib/bsddb/test/test_thread.py?rev=60350&r1=58058&r2=60350
"shutil.rmtree(self.homeDir)" didn`t change between revisions, that
would be false: in fact extra space (" ") was added. Is this a bug
in Roundup?

@tiran
Copy link
Member

tiran commented Jan 28, 2008

I normally don't run the tests with -uall when I merge changes. from the
trunk.

@tiran tiran self-assigned this Jan 28, 2008
@gvanrossum
Copy link
Member

Chris: I think it's worth running all tests before submitting a merge.
Catch them early is what I say. :-)

@tiran
Copy link
Member

tiran commented Jan 28, 2008

Guido van Rossum wrote:

Chris: I think it's worth running all tests before submitting a merge.
Catch them early is what I say. :-)

An ordianry test run already takes a considerable amount of time on my
system. I usually wait until the build bots notify me about a failing
test in the network and bsddb section.

@tiran
Copy link
Member

tiran commented Jan 28, 2008

Fixed in r60394

The bug wasn't detected because the tests couldn't be imported. One test
file still used an absolute import instead of a relative.

@tiran tiran closed this as completed Jan 28, 2008
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tiran tiran

Labels
build The build process and cross-build stdlib Python modules in the Lib dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tiran @gvanrossum