classification
Title: Lib/bsddb/test/test_thread.py uses old 'except' syntax
Type: compile error Stage:
Components: Library (Lib) Versions: Python 3.0
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: christian.heimes Nosy List: christian.heimes, gvanrossum, orivej
Priority: high Keywords:

Created on 2008-01-28 14:40 by orivej, last changed 2008-01-28 18:37 by christian.heimes. This issue is now closed.

Messages (7)
msg61777 - (view) Author: Orivej Desh (orivej) * Date: 2008-01-28 14:40
"except OSError, e:"
(appears twice) should be changed to
"except OSError as e:"
msg61778 - (view) Author: Orivej Desh (orivej) * Date: 2008-01-28 14:44
Appeared in 60350 svnmerge:
http://svn.python.org/view/python/branches/py3k/Lib/bsddb/test/test_thread.py?rev=60350&view=log
http://svn.python.org/view/python/branches/py3k/Lib/bsddb/test/test_thread.py?rev=60350&r1=58058&r2=60350
msg61779 - (view) Author: Orivej Desh (orivej) * Date: 2008-01-28 14:52
If you notice that at
http://svn.python.org/view/python/branches/py3k/Lib/bsddb/test/test_thread.py?rev=60350&r1=58058&r2=60350
"shutil.rmtree(self.homeDir)" didn`t change between revisions, that 
would be false: in fact extra space ("    ") was added. Is this a bug 
in Roundup?
msg61786 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2008-01-28 17:54
I normally don't run the tests with -uall when I merge changes. from the
trunk.
msg61790 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2008-01-28 18:01
Chris: I think it's worth running all tests before submitting a merge. 
Catch them early is what I say. :-)
msg61793 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2008-01-28 18:24
Guido van Rossum wrote:
> Chris: I think it's worth running all tests before submitting a merge. 
> Catch them early is what I say. :-)

An ordianry test run already takes a considerable amount of time on my
system. I usually wait until the build bots notify me about a failing
test in the network and bsddb section.
msg61794 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2008-01-28 18:37
Fixed in r60394

The bug wasn't detected because the tests couldn't be imported. One test
file still used an absolute import instead of a relative.
History
Date User Action Args
2008-01-28 18:37:42christian.heimessetstatus: open -> closed
resolution: accepted -> fixed
messages: + msg61794
2008-01-28 18:24:56christian.heimessetmessages: + msg61793
2008-01-28 18:01:53gvanrossumsetnosy: + gvanrossum
messages: + msg61790
2008-01-28 17:54:49christian.heimessetpriority: high
assignee: christian.heimes
resolution: accepted
messages: + msg61786
nosy: + christian.heimes
2008-01-28 14:52:39orivejsetmessages: + msg61779
2008-01-28 14:44:50orivejsetmessages: + msg61778
2008-01-28 14:40:57orivejcreate