Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiprocessing: remove util.pipe()? #63065

Closed
vstinner opened this issue Aug 28, 2013 · 4 comments
Closed

multiprocessing: remove util.pipe()? #63065

vstinner opened this issue Aug 28, 2013 · 4 comments

Comments

@vstinner
Copy link
Member

BPO 18865
Nosy @vstinner

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2013-08-28.11:04:42.670>
created_at = <Date 2013-08-28.07:36:45.711>
labels = []
title = 'multiprocessing: remove util.pipe()?'
updated_at = <Date 2013-08-28.11:04:42.669>
user = 'https://github.com/vstinner'

bugs.python.org fields:

activity = <Date 2013-08-28.11:04:42.669>
actor = 'sbt'
assignee = 'none'
closed = True
closed_date = <Date 2013-08-28.11:04:42.670>
closer = 'sbt'
components = []
creation = <Date 2013-08-28.07:36:45.711>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 18865
keywords = []
message_count = 4.0
messages = ['196354', '196363', '196370', '196372']
nosy_count = 4.0
nosy_names = ['vstinner', 'neologix', 'python-dev', 'sbt']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue18865'
versions = ['Python 3.4']
@vstinner
Copy link
Member Author

In the implementation of the PEP-446, issue bpo-18571, I replaced multiprocessing.util.pipe() with os.pipe() in the multiprocessing module.

Can we remove the multiprocessing.util.pipe() function? It is not public nor documented.

Charles-François Natali added the comment (in issue bpo-18571):

14.1 --- a/Lib/multiprocessing/util.py
14.2 +++ b/Lib/multiprocessing/util.py

14.13 #
14.14 # Return pipe with CLOEXEC set on fds
14.15 #
14.16 +# Deprecated: os.pipe() creates non-inheritable file descriptors
14.17 +# since Python 3.4
14.18 +#
14.19
14.20 def pipe():
14.21 - import _posixsubprocess
14.22 - return _posixsubprocess.cloexec_pipe()
14.23 + return os.pipe()

I guess you could remove util.pipe() altogether: it wasn't part of the public API.

@sbt
Copy link
Mannequin

sbt mannequin commented Aug 28, 2013

Yes I will remove it. I was planning on doing so when PEP-446 was implemented.

@python-dev
Copy link
Mannequin

python-dev mannequin commented Aug 28, 2013

New changeset 38f028939028 by Richard Oudkerk in branch 'default':
Issue bpo-18865: PEP-446 makes multiprocessing.util.pipe() unnecessary.
http://hg.python.org/cpython/rev/38f028939028

@python-dev
Copy link
Mannequin

python-dev mannequin commented Aug 28, 2013

New changeset 3e397ecedc55 by Victor Stinner in branch 'default':
Issue bpo-18865: remove unused import from multiprocessing.util.spawnv_passfds()
http://hg.python.org/cpython/rev/3e397ecedc55

@sbt sbt mannequin closed this as completed Aug 28, 2013
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vstinner