classification
Title: multiprocessing: remove util.pipe()?
Type: Stage: resolved
Components: Versions: Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: neologix, python-dev, sbt, vstinner
Priority: normal Keywords:

Created on 2013-08-28 07:36 by vstinner, last changed 2013-08-28 11:04 by sbt. This issue is now closed.

Messages (4)
msg196354 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2013-08-28 07:36
In the implementation of the PEP 446, issue #18571, I replaced multiprocessing.util.pipe() with os.pipe() in the multiprocessing module.

Can we remove the multiprocessing.util.pipe() function? It is not public nor documented.

Charles-Fran├žois Natali added the comment (in issue #18571):

   14.1 --- a/Lib/multiprocessing/util.py
   14.2 +++ b/Lib/multiprocessing/util.py

   14.13  #
   14.14  # Return pipe with CLOEXEC set on fds
   14.15  #
   14.16 +# Deprecated: os.pipe() creates non-inheritable file descriptors
   14.17 +# since Python 3.4
   14.18 +#
   14.19
   14.20  def pipe():
   14.21 -    import _posixsubprocess
   14.22 -    return _posixsubprocess.cloexec_pipe()
   14.23 +    return os.pipe()

I guess you could remove util.pipe() altogether: it wasn't part of the public API.
msg196363 - (view) Author: Richard Oudkerk (sbt) * (Python committer) Date: 2013-08-28 09:42
Yes I will remove it.  I was planning on doing so when PEP 446 was implemented.
msg196370 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-08-28 10:27
New changeset 38f028939028 by Richard Oudkerk in branch 'default':
Issue #18865: PEP 446 makes multiprocessing.util.pipe() unnecessary.
http://hg.python.org/cpython/rev/38f028939028
msg196372 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-08-28 10:44
New changeset 3e397ecedc55 by Victor Stinner in branch 'default':
Issue #18865: remove unused import from multiprocessing.util.spawnv_passfds()
http://hg.python.org/cpython/rev/3e397ecedc55
History
Date User Action Args
2013-08-28 11:04:42sbtsetstatus: open -> closed
resolution: fixed
stage: resolved
2013-08-28 10:44:42python-devsetmessages: + msg196372
2013-08-28 10:27:32python-devsetnosy: + python-dev
messages: + msg196370
2013-08-28 09:42:07sbtsetmessages: + msg196363
2013-08-28 07:36:45vstinnercreate