Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_pickle: NULL ptr dereference when PyLong_FromSsize_t() fails #62759

Closed
tiran opened this issue Jul 26, 2013 · 4 comments
Closed

_pickle: NULL ptr dereference when PyLong_FromSsize_t() fails #62759

tiran opened this issue Jul 26, 2013 · 4 comments
Labels
extension-modules C modules in the Modules dir type-crash A hard crash of the interpreter, possibly with a core dump

Comments

@tiran
Copy link
Member

tiran commented Jul 26, 2013

BPO 18559
Nosy @vstinner, @tiran
Files
  • pickle_pylong_null.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2013-07-26.20:46:26.401>
created_at = <Date 2013-07-26.13:45:57.477>
labels = ['extension-modules', 'type-crash']
title = '_pickle: NULL ptr dereference when PyLong_FromSsize_t() fails'
updated_at = <Date 2013-07-26.20:46:26.399>
user = 'https://github.com/tiran'

    bugs.python.org fields:

    activity = <Date 2013-07-26.20:46:26.399>
actor = 'christian.heimes'
assignee = 'none'
closed = True
closed_date = <Date 2013-07-26.20:46:26.401>
closer = 'christian.heimes'
components = ['Extension Modules']
creation = <Date 2013-07-26.13:45:57.477>
creator = 'christian.heimes'
dependencies = []
files = ['31037']
hgrepos = []
issue_num = 18559
keywords = ['patch']
message_count = 4.0
messages = ['193729', '193741', '193742', '193743']
nosy_count = 3.0
nosy_names = ['vstinner', 'christian.heimes', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'crash'
url = 'https://bugs.python.org/issue18559'
versions = ['Python 3.3', 'Python 3.4']
    @tiran
    Copy link
    Member Author

    tiran commented Jul 26, 2013

    Two functions in _pickle Py_DECREF() a variable although it may be NULL. The patch corrects the error handling paths.

    CID 1058277
    CID 1058278

    @tiran tiran added extension-modules C modules in the Modules dir type-crash A hard crash of the interpreter, possibly with a core dump labels Jul 26, 2013
    @vstinner
    Copy link
    Member

    The patch looks good to me.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jul 26, 2013

    New changeset dbdd07657e23 by Christian Heimes in branch '3.3':
    Issue bpo-18559: Fix NULL pointer dereference error in _pickle module
    http://hg.python.org/cpython/rev/dbdd07657e23

    New changeset b33f81974516 by Christian Heimes in branch 'default':
    Issue bpo-18559: Fix NULL pointer dereference error in _pickle module
    http://hg.python.org/cpython/rev/b33f81974516

    @tiran
    Copy link
    Member Author

    tiran commented Jul 26, 2013

    Thanks Victor

    @tiran tiran closed this as completed Jul 26, 2013
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    extension-modules C modules in the Modules dir type-crash A hard crash of the interpreter, possibly with a core dump
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @vstinner @tiran