classification
Title: _pickle: NULL ptr dereference when PyLong_FromSsize_t() fails
Type: crash Stage: resolved
Components: Extension Modules Versions: Python 3.3, Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: christian.heimes, python-dev, vstinner
Priority: normal Keywords: patch

Created on 2013-07-26 13:45 by christian.heimes, last changed 2013-07-26 20:46 by christian.heimes. This issue is now closed.

Files
File name Uploaded Description Edit
pickle_pylong_null.patch christian.heimes, 2013-07-26 13:45
Messages (4)
msg193729 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2013-07-26 13:45 
Two functions in _pickle  Py_DECREF() a variable although it may be NULL. The patch corrects the error handling paths.

CID 1058277
CID 1058278
msg193741 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2013-07-26 20:39 
The patch looks good to me.
msg193742 - (view) Author: Roundup Robot (python-dev) Date: 2013-07-26 20:45 
New changeset dbdd07657e23 by Christian Heimes in branch '3.3':
Issue #18559: Fix NULL pointer dereference error in _pickle module
http://hg.python.org/cpython/rev/dbdd07657e23

New changeset b33f81974516 by Christian Heimes in branch 'default':
Issue #18559: Fix NULL pointer dereference error in _pickle module
http://hg.python.org/cpython/rev/b33f81974516
msg193743 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2013-07-26 20:46 
Thanks Victor
History
Date User Action Args
2013-07-26 20:46:26christian.heimessetstatus: open -> closed
resolution: fixed
messages: + msg193743

stage: patch review -> resolved
2013-07-26 20:45:57python-devsetnosy: + python-dev
messages: + msg193742
2013-07-26 20:39:43vstinnersetnosy: + vstinner
messages: + msg193741
2013-07-26 13:45:57christian.heimescreate