Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing declaration in readline.c #44863

Closed
abalkin opened this issue Apr 18, 2007 · 2 comments
Closed

missing declaration in readline.c #44863

abalkin opened this issue Apr 18, 2007 · 2 comments

Comments

@abalkin
Copy link
Member

abalkin commented Apr 18, 2007

BPO 1703270
Nosy @abalkin
Files
  • readline.patch: diff against revision 54869
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2007-04-19.05:53:04.000>
created_at = <Date 2007-04-18.21:43:45.000>
labels = []
title = 'missing declaration in readline.c'
updated_at = <Date 2007-04-19.05:53:04.000>
user = 'https://github.com/abalkin'

    bugs.python.org fields:

    activity = <Date 2007-04-19.05:53:04.000>
actor = 'nnorwitz'
assignee = 'nnorwitz'
closed = True
closed_date = None
closer = None
components = ['None']
creation = <Date 2007-04-18.21:43:45.000>
creator = 'belopolsky'
dependencies = []
files = ['7944']
hgrepos = []
issue_num = 1703270
keywords = ['patch']
message_count = 2.0
messages = ['52448', '52449']
nosy_count = 2.0
nosy_names = ['nnorwitz', 'belopolsky']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1703270'
versions = []
    @abalkin
    Copy link
    Member Author

    abalkin commented Apr 18, 2007

    If HAVE_RL_COMPLETION_MATCHES is not defined, readline.c code does not define completion_matches macro in an apparent hope that completion_matches will be linked to a n internal rl function. Attached patch adds the missing extern declaration to supress compiler warnings.

    Currently gcc complains as follows:

    Modules/readline.c:681: warning: implicit declaration of function `completion_matches'
    Modules/readline.c:681: warning: return makes pointer from integer without a cast

    @abalkin abalkin closed this as completed Apr 18, 2007
    @abalkin abalkin closed this as completed Apr 18, 2007
    @nnorwitz
    Copy link
    Mannequin

    nnorwitz mannequin commented Apr 19, 2007

    Thanks for the patch!

    Committed revision 54874.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @abalkin