This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: missing declaration in readline.c
Type: Stage:
Components: None Versions:
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: nnorwitz Nosy List: belopolsky, nnorwitz
Priority: normal Keywords: patch

Created on 2007-04-18 21:43 by belopolsky, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
readline.patch belopolsky, 2007-04-18 21:43 diff against revision 54869
Messages (2)
msg52448 - (view) Author: Alexander Belopolsky (belopolsky) * (Python committer) Date: 2007-04-18 21:43
If HAVE_RL_COMPLETION_MATCHES is not defined, readline.c code does not define completion_matches macro in an apparent hope that completion_matches will be linked to a n internal rl function. Attached patch adds the missing extern declaration to supress compiler warnings.

Currently gcc complains as follows:

Modules/readline.c:681: warning: implicit declaration of function `completion_matches'
Modules/readline.c:681: warning: return makes pointer from integer without a cast
msg52449 - (view) Author: Neal Norwitz (nnorwitz) * (Python committer) Date: 2007-04-19 05:53
Thanks for the patch!

Committed revision 54874.
History
Date User Action Args
2022-04-11 14:56:23adminsetgithub: 44863
2007-04-18 21:43:45belopolskycreate