Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PC new-logo-based icon set #43372

Closed
bobince mannequin opened this issue May 17, 2006 · 14 comments
Closed

PC new-logo-based icon set #43372

bobince mannequin opened this issue May 17, 2006 · 14 comments
Assignees
@loewis
Labels
OS-windows release-blocker type-feature A feature request or enhancement

Comments

@bobince
Copy link
Mannequin

bobince mannequin commented May 17, 2006

BPO 1490384
Nosy @loewis, @terryjreedy, @hroncok, @miss-islington
PRs
  • bpo-38439: Add 256px IDLE icon #17473
  • [3.8] bpo-38439: Add 256px IDLE icon (GH-17473) #19646
  • [3.7] bpo-38439: Add 256px IDLE icon (GH-17473) #19647
    		•
    Files
  • win32-icons.zip: PC/win32 icon set
  • win32-icons2.zip: Icon set - revised
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/loewis'
closed_at = <Date 2020-04-22.07:40:05.922>
created_at = <Date 2006-05-17.16:59:50.000>
labels = ['type-feature', 'OS-windows', 'release-blocker']
title = 'PC new-logo-based icon set'
updated_at = <Date 2020-04-22.07:40:05.922>
user = 'https://bugs.python.org/bobince'

    bugs.python.org fields:

    activity = <Date 2020-04-22.07:40:05.922>
actor = 'miss-islington'
assignee = 'loewis'
closed = True
closed_date = None
closer = None
components = ['Windows']
creation = <Date 2006-05-17.16:59:50.000>
creator = 'bobince'
dependencies = []
files = ['7262', '7263']
hgrepos = []
issue_num = 1490384
keywords = ['patch']
message_count = 14.0
messages = ['50272', '50273', '50274', '50275', '50276', '50277', '50278', '50279', '50280', '50281', '50282', '366984', '366986', '366988']
nosy_count = 5.0
nosy_names = ['loewis', 'terry.reedy', 'bobince', 'hroncok', 'miss-islington']
pr_nums = ['17473', '19646', '19647']
priority = 'release blocker'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue1490384'
versions = ['Python 2.5']
    @bobince
    Copy link
    Mannequin Author

    bobince mannequin commented May 17, 2006

    Following positive discussion on -dev, here's the
    updated version of the PC/py*.ico files I hacked up a
    while ago.

    The attachment is a ZIP, not a patch, as it contains
    only binaries. Also available as tgz:

    http://doxdesk.com/img/software/py/win32-icons.tar.gz

    Also possibly of interest:

    http://doxdesk.com/img/software/py/icons3.zip

    This attachment contains only the simple replacement
    files; the icons3 ZIP also contains:

    • source
    • versions including Windows Vista large icons
      (probably not worth including at this point as they're
      quite sizable and no-one is using Vista yet)
    • an egg icon
      (there is currently no installer/shell support for
      eggs,
      but could be worth adding in future)
    • a new installer side banner
      (this has not currently seen any discussion on -dev,
      but may be worth considering if the intention is to
      leave behind the purple/green snake branding)

    @bobince bobince mannequin closed this as completed May 17, 2006
    @bobince bobince mannequin added the release-blocker label May 17, 2006
    @bobince bobince mannequin assigned loewis May 17, 2006
    @bobince bobince mannequin closed this as completed May 17, 2006
    @bobince bobince mannequin assigned loewis May 17, 2006
    @bobince bobince mannequin added the OS-windows label May 17, 2006
    @loewis
    Copy link
    Mannequin

    loewis mannequin commented May 19, 2006

    Logged In: YES
    user_id=21627

    Thanks! Are you willing to contribute them to the PSF, under
    the terms of the contributor agreement at

    http://www.python.org/psf/contrib/contrib-form/

    ?

    @bobince
    Copy link
    Mannequin Author

    bobince mannequin commented May 19, 2006

    Logged In: YES
    user_id=311085

    Sure, no worries. I'll fax over the -python version since I
    have ancient contributions to cover too.

    @loewis
    Copy link
    Mannequin

    loewis mannequin commented May 22, 2006

    Logged In: YES
    user_id=21627

    Thanks for the patch. I have committed it as r46063. I put a
    demo installer containing them at

    http://www.dcl.hpi.uni-potsdam.de/home/loewis/python-2.5.13290.msi

    I would also like to add the source files, but I have
    difficulties figuring out what they are. There is a source
    directory; with:

    • baselogo.svg; I assume this is a source file
    • icons.svgz; can't figure out what this is
    • source.xar; not sure either
    • a directory called png, with many png file - I expect
      that these aren't source files, are they?

    @bobince
    Copy link
    Mannequin Author

    bobince mannequin commented May 26, 2006

    Logged In: YES
    user_id=311085

    I put a demo installer containing them

    Seems to work OK. The thanks at the end still attributes the
    graphic to Erik though; I'm not after an ack there myself,
    but changing the text to not imply the current graphic is
    his one may be appropriate.

    baselogo.svg; I assume this is a source file

    Yes. This is just the Python logo itself (the gradient
    version as used on the new website), in vector format.

    icons.svgz; can't figure out what this is

    Same as source.xar, but exported as W3C standard SVG format
    for wider compatibility [compressed, hence the 'z'].

    Unfortunately because SVG cannot reproduce some of effects
    used, and because the SVG export path is currently quite
    bad, it's not really directly usable, but it might be of use
    to anyone who wants to hack on the graphics but doesn't use
    Xara.

    source.xar; not sure either

    This is the primary vector graphics source of the icons -
    the other SVG and PNG files are just there because other
    people requested them.

    It's in Xara format, a previously proprietary graphics
    application which has now gone open-source and is heading
    rapidly towards being usable on Linux, but isn't quite there
    yet.

    a directory called png, with many png file - I expect
    that these aren't source files, are they?

    Nope, they're just exactly the same content as in the
    (with-vista) .ico files, just supplied as PNG for anyone who
    wants to fiddle with them in a more accessible bitmap format.

    @loewis
    Copy link
    Mannequin

    loewis mannequin commented May 26, 2006

    Logged In: YES
    user_id=21627

    Ok, I will then do the following changes still:

    • add baselogo.svg and source.xar (ignore all the other files),
    • remove the attribution for Erik (sorry for missing that)

    @loewis
    Copy link
    Mannequin

    loewis mannequin commented May 28, 2006

    Logged In: YES
    user_id=21627

    Committed the rest as r46503. Thanks again!

    @bobince
    Copy link
    Mannequin Author

    bobince mannequin commented May 30, 2006

    Logged In: YES
    user_id=311085

    No probs and ta!

    However...

    I've got more altered icons, attached and at
    http://doxdesk.com/img/software/py/win32-icons2.zip . Sorry
    for the inconvenience - pretty sure these are 'final'.

    The problem with the old files? Well it seems there's a bug
    in Windows that can cause redraw errors on 32-bit
    alpha-blended XP icons. I can't find any doc on this at all,
    but from experiment it seems that it can occur when icons
    are partially redrawn instead of drawn all at once. This is
    most easily provoked by slowly dragging a window on top of
    an Explorer window in Tiles/Icons/List mode, to reveal the
    icon underneath.

    It looks to be an arithmetic overflow in compositing: when a
    nearly-transparent white pixel being plotted onto pure white
    background in this partial-redraw code, a black pixel can
    unexpectedly result, with poor-looking results. (Thanks,
    Windows.)

    I've hacked the bitmaps to avoid places where they're
    white-and-transparent enough to be able to provoke this
    aggravating occasional behaviour. Also while I'm at it, I've
    removed the 256 colour 48x48 icons, since it saves a few K
    and there's almost no practical case where they're of benefit.

    cheers,

    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Jun 3, 2006

    Logged In: YES
    user_id=21627

    Hmm, I'm getting an http error 404 when accessing
    http://doxdesk.com/img/software/py/win32-icons2.zip

    @bobince
    Copy link
    Mannequin Author

    bobince mannequin commented Jun 3, 2006

    Logged In: YES
    user_id=311085

    Oh! Sorry - it's there now, and attached, as I had meant to
    do originally.

    No changes to any of the source files, as it's purely a
    .ICO-level fix.

    Cheers,

    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Jun 3, 2006

    Logged In: YES
    user_id=21627

    Thanks, committed as 46610.

    @terryjreedy terryjreedy added type-feature A feature request or enhancement labels Apr 18, 2020
    @terryjreedy
    Copy link
    Member

    New changeset 3a69f3c by Miro Hrončok in branch 'master':
    bpo-38439: Add 256px IDLE icon (GH-17473)
    3a69f3c

    @miss-islington
    Copy link
    Contributor

    New changeset abdfb3b by Miss Islington (bot) in branch '3.7':
    bpo-38439: Add 256px IDLE icon (GH-17473)
    abdfb3b

    @miss-islington
    Copy link
    Contributor

    New changeset 3a55450 by Miss Islington (bot) in branch '3.8':
    bpo-38439: Add 256px IDLE icon (GH-17473)
    3a55450

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @loewis loewis

    Labels
    OS-windows release-blocker type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @terryjreedy @miss-islington