Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression for http.client read() #57922

Closed
rosslagerwall mannequin opened this issue Jan 4, 2012 · 5 comments
Closed

Regression for http.client read() #57922

rosslagerwall mannequin opened this issue Jan 4, 2012 · 5 comments
Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@rosslagerwall
Copy link
Mannequin

rosslagerwall mannequin commented Jan 4, 2012

BPO 13713
Nosy @orsenthil, @pitrou
Files
  • test.py: test program
  • readinto_chunked.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2012-01-04.18:00:54.064>
created_at = <Date 2012-01-04.16:38:39.976>
labels = ['type-bug', 'library']
title = 'Regression for http.client read()'
updated_at = <Date 2012-01-04.18:00:54.062>
user = 'https://bugs.python.org/rosslagerwall'

    bugs.python.org fields:

    activity = <Date 2012-01-04.18:00:54.062>
actor = 'pitrou'
assignee = 'none'
closed = True
closed_date = <Date 2012-01-04.18:00:54.064>
closer = 'pitrou'
components = ['Library (Lib)']
creation = <Date 2012-01-04.16:38:39.976>
creator = 'rosslagerwall'
dependencies = []
files = ['24138', '24140']
hgrepos = []
issue_num = 13713
keywords = ['patch']
message_count = 5.0
messages = ['150615', '150623', '150624', '150626', '150628']
nosy_count = 5.0
nosy_names = ['orsenthil', 'pitrou', 'rosslagerwall', 'python-dev', 'Jon.Kuhn']
pr_nums = []
priority = 'critical'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue13713'
versions = ['Python 3.3']
    @rosslagerwall
    Copy link
    Mannequin Author

    rosslagerwall mannequin commented Jan 4, 2012

    806cfe39f729 introduced a regression for http.client read(len).

    To see this:
    $ ./python test.py
    $ wget http://archives.fedoraproject.org/pub/archive/fedora/linux/core/1/SRPMS/
    $ diff index.html index2.html

    This is a difference in the files (which there shouldn't be).

    The change which introduced the problem was:
    changeset: 73875:806cfe39f729
    user: Antoine Pitrou <solipsis@pitrou.net>
    date: Tue Dec 06 22:33:57 2011 +0100
    summary: Issue bpo-13464: Add a readinto() method to http.client.HTTPResponse.

    @rosslagerwall rosslagerwall mannequin added stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Jan 4, 2012
    @pitrou
    Copy link
    Member

    pitrou commented Jan 4, 2012

    The fix is quite trivial. Here is a patch + tests.

    @rosslagerwall
    Copy link
    Mannequin Author

    rosslagerwall mannequin commented Jan 4, 2012

    The patch looks right and seems to fix the issue. Thanks :-)

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jan 4, 2012

    New changeset 4b21f651eeee by Antoine Pitrou in branch 'default':
    Issue bpo-13713: fix a regression in HTTP chunked reading after 806cfe39f729
    http://hg.python.org/cpython/rev/4b21f651eeee

    @pitrou
    Copy link
    Member

    pitrou commented Jan 4, 2012

    Ok, committed!
    (Jon, don't worry, such things happen :-))

    @pitrou pitrou closed this as completed Jan 4, 2012
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @pitrou